Don't emit @main into SIL #40767
Merged
Don't emit @main into SIL #40767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to control when the attribute gets emitted so we need to make the attribute non-simple.
We've already generated the parts necessary to handle `@main` during SILGen. Keeping the attribute on the struct means that re-ingesting the SIL will fail because it tries to re-create the implicit `$main` function resulting in the following error message: error: invalid redeclaration of synthesized static method '$main()' static func $main()
|
@swift-ci please test |
nate-chandler
approved these changes
Jan 7, 2022
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picking #40601
We emit all the necessary entry point bits directly into SIL. Specifically, Entrypoint.$main.
When re-injesting SIL files, @main handling would re-trigger, attempting to add another Entrypoint.$main resulting in the following error message: error: invalid redeclaration of synthesized static method '$main()'.
We don't need to keep the attribute after we've generated the main function, so drop it.
https://bugs.swift.org/browse/SR-14957
rdar://80971052