[Sema] Downgrade to a warning public imports of an underlying private module #40770
+29
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… module Diagnostics of public imports of private modules are more likely to be wrong about imports of the underlying module from a Swift overlay due to project configuration/installation, or the fact that private overlays are installed in the same folder as public ones. Let's always downgrade these diagnostics to warnings to help landing the rest of the diagnostics as errors. rdar://87262431
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diagnostics of public imports of private modules are more likely to be wrong about imports of the underlying module from a Swift overlay due to weird project configuration/installation, or the fact that private overlays are installed in the same folder as public ones. Let's always downgrade these diagnostics to warnings to help landing the rest of the diagnostics as errors.
rdar://87262431