Skip to content

[allocbox-to-stack] Loosen an assert. #40787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

gottesmm
Copy link
Contributor

We should be able to accept mark_uninitialized in this position. The assert was
just being careful so that the codegen that we accept here is constricted
explicitly.

rdar://86535218
(cherry picked from commit 3e9254c)

We should be able to accept mark_uninitialized in this position. The assert was
just being careful so that the codegen that we accept here is constricted
explicitly.

rdar://86535218
(cherry picked from commit 3e9254c)
@gottesmm gottesmm requested a review from atrick January 10, 2022 21:13
@gottesmm
Copy link
Contributor Author

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 6dd5545

@gottesmm
Copy link
Contributor Author

@swift-ci test macOS platform

@gottesmm
Copy link
Contributor Author

macOS failure was a missing watchOS simulator.

@gottesmm
Copy link
Contributor Author

I told Mishal about it.

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 6dd5545

@gottesmm
Copy link
Contributor Author

@swift-ci test macOS platform

Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought mark_uninitialized was always supposed to be directly on the alloc_box. I'm not sure why we would allow anything else!

@gottesmm gottesmm merged commit aec1c8c into swiftlang:release/5.6 Jan 12, 2022
@gottesmm gottesmm deleted the release/5.6/rdar86535218 branch January 12, 2022 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants