Skip to content

RequirementMachine: Two more fixes for -requirement-machine-protocol-signatures=verify #40795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

slavapestov
Copy link
Contributor

Only three test failures remain with this flag enabled:

  • Generics/concrete_conformances_in_protocol.swift
  • Generics/requirement_inference.swift
  • Generics/sr12531.swift

@slavapestov slavapestov force-pushed the rqm-property-unification-rewrite-path-fixes branch 2 times, most recently from 16baa62 to 04f7973 Compare January 11, 2022 04:32
This will replace the 'concrete type in domain' hack. Instead of
finding some other type parameter with the same concrete type and a
compatible starting symbol, this finds a prefix of the original
term. This allows the induced same-type requirement to be described
with a rewrite path.
@slavapestov slavapestov force-pushed the rqm-property-unification-rewrite-path-fixes branch from 04f7973 to f674ca9 Compare January 12, 2022 02:44
@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test macOS

@slavapestov slavapestov merged commit 02c7eba into swiftlang:main Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant