[Distributed] Fix _executeDistributedFunction resume and result buffer
#40814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this is a special function, `calleeContext` doesn't point to a direct parent but instead both parent context (uninitialized) and resume function are passed as last arguments which means that `callContext` has to act as an intermediate context in call to accessor.
…utedTarget` `RawPointer?` is lowered into a two arguments since it's a struct, to make it easy let's just allocate an empty pointer for `Void` result.
…ferent result types
|
@swift-ci please test |
ktoso
reviewed
Jan 12, 2022
| @@ -277,7 +274,7 @@ func _executeDistributedTarget( | |||
| on actor: AnyObject, // DistributedActor | |||
| _ targetName: UnsafePointer<UInt8>, _ targetNameLength: UInt, | |||
| argumentBuffer: Builtin.RawPointer, // HeterogeneousBuffer of arguments | |||
| resultBuffer: Builtin.RawPointer? | |||
| resultBuffer: Builtin.RawPointer | |||
ktoso
approved these changes
Jan 12, 2022
| callContext->Parent = callerContext; | ||
| callContext->ResumeParent = resumeFunc; | ||
|
|
||
| calleeContext->Parent = callContext; |
There was a problem hiding this comment.
That's tricky... thanks a lot for digging through!
|
Build failed |
|
@swift-ci please test macOS platform |
|
Looking good, let's merge 👍 I'll send a mini PR for the parameters :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swift_distributed_execute_targetresume back to the correct fame.Since
swift_distributed_execute_targetis not a regular async function, it needs to do some extrabookkeeping before accessor could be called.
Drop optionality from result buffer, works fine with
Voidand makes it simpler to implement the accessor.Add some more tests to make sure that different result types are handled correctly.