Skip to content

Migrate more options to StdlibOptions.cmake #40840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2022
Merged

Migrate more options to StdlibOptions.cmake #40840

merged 1 commit into from
Jan 14, 2022

Conversation

edymtt
Copy link
Contributor

@edymtt edymtt commented Jan 13, 2022

At the same time, convert the conditions that test for Darwin platforms
to use SWIFT_DARWIN_PLATFORMS instead.

Addresses rdar://87147214

@edymtt
Copy link
Contributor Author

edymtt commented Jan 13, 2022

@swift-ci please test

@edymtt
Copy link
Contributor Author

edymtt commented Jan 13, 2022

@swift-ci please test Apple Silicon

@edymtt
Copy link
Contributor Author

edymtt commented Jan 13, 2022

@swift-ci please build toolchain

@edymtt
Copy link
Contributor Author

edymtt commented Jan 13, 2022

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please test with toolchain and preset

compnerd
compnerd approved these changes Jan 13, 2022
View reviewed changes
@swift-ci
Copy link
Contributor

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - 52d1e1af785e43b891ad05e56612b7c84695b529

Install command
tar zxf swift-PR-40840-775-ubuntu16.04.tar.gz
More info

@edymtt
Migrate more options to StdlibOptions.cmake
447a167 
At the same time, convert the conditions that test for Darwin platforms
to use `SWIFT_DARWIN_PLATFORMS` instead.

Addresses rdar://87147214
@edymtt edymtt force-pushed the move-more-options-to-stdliboptions branch from 52d1e1a to 447a167 Compare January 13, 2022 18:46
@edymtt
Copy link
Contributor Author

edymtt commented Jan 13, 2022

@swift-ci please test

@edymtt
Copy link
Contributor Author

edymtt commented Jan 13, 2022

@swift-ci please test Apple Silicon

@edymtt
Copy link
Contributor Author

edymtt commented Jan 13, 2022

@swift-ci please build toolchain

@edymtt
Copy link
Contributor Author

edymtt commented Jan 13, 2022

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please test with toolchain and preset

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 447a167

compnerd
compnerd approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@edymtt
Copy link
Contributor Author

edymtt commented Jan 13, 2022

@swift-ci please test macOS

@swift-ci
Copy link
Contributor

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - 447a167

Install command
tar zxf swift-PR-40840-776-ubuntu16.04.tar.gz
More info

@edymtt
Copy link
Contributor Author

edymtt commented Jan 14, 2022

@swift-ci please build toolchain macOS platform

@swift-ci
Copy link
Contributor

macOS Toolchain
Download Toolchain
Git Sha - 447a167

Install command
tar -zxf swift-PR-40840-1288-osx.tar.gz --directory ~/

@edymtt edymtt merged commit 2daff9f into swiftlang:main Jan 14, 2022
@edymtt edymtt deleted the move-more-options-to-stdliboptions branch January 17, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@drexin drexin drexin approved these changes

@gottesmm gottesmm Awaiting requested review from gottesmm

@kubamracek kubamracek Awaiting requested review from kubamracek

@Catfish-Man Catfish-Man Awaiting requested review from Catfish-Man

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edymtt @swift-ci @compnerd @drexin