Skip to content

[5.6] ABI checker: check validity of extended nominals before continue #40854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

nkcsgexi
Copy link
Contributor

@nkcsgexi nkcsgexi commented Jan 14, 2022

Radar: rdar://87150470
Description: Fix an ABI checker crash on invalid code due to missing extended type pointer from an extension declaration.
Risk: Low
Testing: PR testing
Original PR: #40785
Reviewer: @xymus

@nkcsgexi nkcsgexi requested a review from a team as a code owner January 14, 2022 02:27
@nkcsgexi
Copy link
Contributor Author

@swift-ci please test

@nkcsgexi nkcsgexi requested a review from xymus January 14, 2022 02:29
Copy link
Contributor

@xymus xymus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good as a quick fix. As a more general fix we should not generate ABI descriptors in builds allowing errors. Until then we may see more errors in this logic when it runs on invalid code.

@nkcsgexi nkcsgexi merged commit 52d8fdf into swiftlang:release/5.6 Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants