[5.5] Don't build arm64e slices of the back-deployed libswift_Concurrency.dylib #40858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ylib. The arm64e ABI is not stable, so there is no reason to build or ship arm64e slices of the back-deployed libswift_Concurrency.dylib. Moreover, these slices interact poorly with bitcode_strip tool, resulting in a shared library that iOS will refuse to load in certain circumstances. Fixes rdar://85752735 / FB9780976. Thank you to Jay Muthialu and Keith Smiley for helping debug this issue!
|
@swift-ci please test |
edymtt
approved these changes
Jan 14, 2022
keith
approved these changes
Jan 14, 2022
airspeedswift
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arm64e ABI is not stable, so there is no reason to build or ship
arm64e slices of the back-deployed libswift_Concurrency.dylib. Moreover,
these slices interact poorly with bitcode_strip tool, resulting in
a shared library that iOS will refuse to load in certain circumstances.
Fixes rdar://85752735 / FB9780976.
Thank you to Jay Muthialu and Keith Smiley for helping debug this issue!