Skip to content

[stdlib] Deprecate ContiguousArray (do not merge yet) #4086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2016

Conversation

dabrahams
Copy link
Contributor

@dabrahams dabrahams commented Aug 8, 2016

I want to come back and try to turn it into a typealias, but as that is not API-changing it can wait.

The performance team reports that it's 2x slower than Array, and even if
it weren't, it would be obsoleted by the introduction of eager bridging.
@dabrahams
Copy link
Contributor Author

@swift-ci Please test

@karwa
Copy link
Contributor

karwa commented Aug 8, 2016

I encountered a case recently where ContiguousArray was reproducibly 2x faster than standard Array. I wouldn't like to see it go (https://bugs.swift.org/browse/SR-2196)

@dabrahams
Copy link
Contributor Author

dabrahams commented Aug 8, 2016

on Sun Aug 07 2016, karwa <notifications-AT-i.8713187.xyz> wrote:

I encountered a case recently where ContiguousArray was reproducibly
2x faster than standard Array. I wouldn't like to see it go
(https://bugs.swift.org/browse/SR-2196)

@karwa I can't reproduce that effect. Details at
https://bugs.swift.org/browse/SR-2196?focusedCommentId=16893&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16893

-Dave

@dabrahams
Copy link
Contributor Author

@swift-ci Please test Linux platform

@tkremenek tkremenek merged commit 0cdcd18 into master Aug 9, 2016
@jrose-apple jrose-apple deleted the deprecate-contiguousarray branch August 17, 2016 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants