[Distributed] Metadata: Refactor demangling of function types from method mangled names #40864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xedin
commented
Jan 14, 2022
xedin
commented
- Extract common logic across count, result and parameter type demangling
- Add support for demangling of generic functions
- Fix handling of single unlabeled parameter types
…thod mangled names - Extract common logic across count, result and parameter type demangling - Add support for demangling of generic functions - Fix handling of single unlabeled parameter types
xedin
force-pushed
the
fixes-for-dist-metadata-retrieval
branch
from
4231888 to
4746370
Compare
|
@swift-ci please test |
ktoso
reviewed
Jan 16, 2022
| /// representation. | ||
| static NodePointer extractFunctionTypeFromMethod(Demangler &demangler, | ||
| const char *typeNameStart, | ||
| size_t typeNameLength) { |
ktoso
approved these changes
Jan 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.