[NFC] Fix typo and swap single quotes for some double quotes #40894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's no preference for single or double quotes - the efficiency of either In the interest of minimizing code churn, I would take the typo fix but I don't think it's worth it to go through and regrade all the usages of string/char literals in the printers. |
|
I understand that enforcing a single/double quote policy everywhere is unmanageable. Could you still merge the quote changes along with the typo fix? |
|
@swift-ci smoke test and merge |
xwu
changed the title
|
Pull request is not mergeable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #40888. I accidentally deleted my
patch-12branch while messing around with some stuff, thus closing my pull request.