-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Enable lazy ClangImporter diagnostics by default #40903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
test/ClangImporter/experimental_clang_importer_diagnostics_bridging_header.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
test/ClangImporter/experimental_diagnostics_incomplete_types.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
test/ClangImporter/experimental_diagnostics_incomplete_types_negative.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
test/ClangImporter/experimental_diagnostics_lookup_accuracy.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72 changes: 72 additions & 0 deletions
72
test/ClangImporter/experimental_diagnostics_no_noise.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| // RUN: not %target-swift-frontend(mock-sdk: %clang-importer-sdk) -enable-objc-interop -typecheck %s 2>&1 | %FileCheck %s --strict-whitespace | ||
|
|
||
| // REQUIRES: objc_interop | ||
|
|
||
| // Referencing a single declaration should only surface diagnostics about that declaration, no more | ||
|
|
||
| import IncompleteTypes | ||
| import cfuncs | ||
| import ctypes | ||
|
|
||
| // CHECK-NOT: note | ||
| // CHECK-NOT: warning | ||
| // CHECK-NOT: error | ||
| let bar = Bar() | ||
| _ = bar.methodReturningForwardDeclaredInterface() | ||
| // CHECK: experimental_diagnostics_no_noise.swift:{{[0-9]+}}:{{[0-9]+}}: error: value of type 'Bar' has no member 'methodReturningForwardDeclaredInterface' | ||
| // CHECK-NEXT: _ = bar.methodReturningForwardDeclaredInterface() | ||
| // CHECK-NEXT: ~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| // CHECK-NEXT: IncompleteTypes.h:{{[0-9]+}}:{{[0-9]+}}: note: method 'methodReturningForwardDeclaredInterface' not imported | ||
| // CHECK-NEXT: - (ForwardDeclaredInterface *) methodReturningForwardDeclaredInterface; | ||
| // CHECK-NEXT: ^ | ||
| // CHECK-NEXT: IncompleteTypes.h:{{[0-9]+}}:{{[0-9]+}}: note: return type not imported | ||
| // CHECK-NEXT: - (ForwardDeclaredInterface *) methodReturningForwardDeclaredInterface; | ||
| // CHECK-NEXT: ^ | ||
| // CHECK-NEXT: IncompleteTypes.h:{{[0-9]+}}:{{[0-9]+}}: note: interface 'ForwardDeclaredInterface' is incomplete | ||
| // CHECK-NEXT: - (ForwardDeclaredInterface *) methodReturningForwardDeclaredInterface; | ||
| // CHECK-NEXT: ^ | ||
| // CHECK-NEXT: IncompleteTypes.h:{{[0-9]+}}:{{[0-9]+}}: note: interface 'ForwardDeclaredInterface' forward declared here | ||
| // CHECK-NEXT: @class ForwardDeclaredInterface; | ||
| // CHECK-NEXT: ^ | ||
|
|
||
| // CHECK-NOT: note | ||
| // CHECK-NOT: warning | ||
| // CHECK-NOT: error | ||
| unsupported_parameter_type(1,2) | ||
| // CHECK: experimental_diagnostics_no_noise.swift:{{[0-9]+}}:{{[0-9]+}}: error: cannot find 'unsupported_parameter_type' in scope | ||
| // CHECK-NEXT: unsupported_parameter_type(1,2) | ||
| // CHECK-NEXT: ^~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| // CHECK-NEXT: cfuncs.h:{{[0-9]+}}:{{[0-9]+}}: note: function 'unsupported_parameter_type' not imported | ||
| // CHECK-NEXT: int unsupported_parameter_type(int param1, _Complex int param2); | ||
| // CHECK-NEXT: {{^}}^ | ||
| // CHECK-NEXT: cfuncs.h:{{[0-9]+}}:{{[0-9]+}}: note: parameter 'param2' not imported | ||
| // CHECK-NEXT: int unsupported_parameter_type(int param1, _Complex int param2); | ||
| // CHECK-NEXT: {{^}} ^ | ||
| // CHECK-NEXT: cfuncs.h:{{[0-9]+}}:{{[0-9]+}}: note: built-in type 'Complex' not supported | ||
| // CHECK-NEXT: int unsupported_parameter_type(int param1, _Complex int param2); | ||
| // CHECK-NEXT: {{^}} ^ | ||
|
|
||
| // CHECK-NOT: note | ||
| // CHECK-NOT: warning | ||
| // CHECK-NOT: error | ||
| let s: PartialImport | ||
| s.c = 5 | ||
| // CHECK: experimental_diagnostics_no_noise.swift:{{[0-9]+}}:{{[0-9]+}}: error: value of type 'PartialImport' has no member 'c' | ||
| // CHECK-NEXT: s.c = 5 | ||
| // CHECK-NEXT: ~ ^ | ||
| // CHECK-NEXT: ctypes.h:{{[0-9]+}}:{{[0-9]+}}: note: field 'c' not imported | ||
| // CHECK-NEXT: int _Complex c; | ||
| // CHECK-NEXT: ^ | ||
| // CHECK-NEXT: ctypes.h:{{[0-9]+}}:{{[0-9]+}}: note: built-in type 'Complex' not supported | ||
| // CHECK-NEXT: int _Complex c; | ||
| // CHECK-NEXT: ^ | ||
| // CHECK-NEXT: ctypes.PartialImport:{{[0-9]+}}:{{[0-9]+}}: note: did you mean 'a'? | ||
| // CHECK-NEXT: public var a: Int32 | ||
| // CHECK-NEXT: ^ | ||
| // CHECK-NEXT: ctypes.PartialImport:{{[0-9]+}}:{{[0-9]+}}: note: did you mean 'b'? | ||
| // CHECK-NEXT: public var b: Int32 | ||
| // CHECK-NEXT: ^ | ||
|
|
||
| // CHECK-NOT: note | ||
| // CHECK-NOT: warning | ||
| // CHECK-NOT: error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| // RUN: not %target-swift-frontend(mock-sdk: %clang-importer-sdk) -disable-experimental-clang-importer-diagnostics -enable-objc-interop -typecheck %s 2>&1 | %FileCheck %s --strict-whitespace | ||
|
|
||
| // REQUIRES: objc_interop | ||
|
|
||
| import cfuncs | ||
| import ctypes | ||
| import IncompleteTypes | ||
|
|
||
| // CHECK-NOT: warning | ||
| // CHECK-NOT: error | ||
| // CHECK-NOT: note | ||
| let bar = Bar() | ||
| _ = bar.methodReturningForwardDeclaredInterface() | ||
| // CHECK: experimental_diagnostics_opt_out.swift:{{[0-9]+}}:{{[0-9]+}}: error: value of type 'Bar' has no member 'methodReturningForwardDeclaredInterface' | ||
| // CHECK-NOT: warning | ||
| // CHECK-NOT: error | ||
| // CHECK-NOT: note | ||
|
|
||
| // CHECK-NOT: warning | ||
| // CHECK-NOT: error | ||
| let s: PartialImport | ||
| s.c = 5 | ||
| // CHECK: experimental_diagnostics_opt_out.swift:{{[0-9]+}}:{{[0-9]+}}: error: value of type 'PartialImport' has no member 'c' | ||
| // CHECK: ctypes.PartialImport:{{[0-9]+}}:{{[0-9]+}}: note: did you mean 'a'? | ||
| // CHECK: ctypes.PartialImport:{{[0-9]+}}:{{[0-9]+}}: note: did you mean 'b'? | ||
| // CHECK-NOT: warning | ||
| // CHECK-NOT: error | ||
| // CHECK-NOT: note | ||
|
|
||
| // CHECK-NOT: warning | ||
| // CHECK-NOT: error | ||
| unsupported_parameter_type(1,2) | ||
| // CHECK: experimental_diagnostics_opt_out.swift:{{[0-9]+}}:{{[0-9]+}}: error: cannot find 'unsupported_parameter_type' in scope | ||
| // CHECK-NOT: warning | ||
| // CHECK-NOT: error | ||
| // CHECK-NOT: note | ||
2 changes: 1 addition & 1 deletion
2
test/ClangImporter/experimental_diagnostics_unreferenced_cmacros.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: Remove unnecessary CHECK-NOTs