Skip to content

[cxx-interop] Re-land part of 6ba7a1e. Fix an issue with extending nested namespaces across modules. #40905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

zoecarver
Copy link
Contributor

No one should be using C++ interop yet, so this part of the change cannot break anyone (as it only touches namespaces).

@zoecarver zoecarver added the c++ interop Feature: Interoperability with C++ label Jan 19, 2022
@zoecarver zoecarver requested review from hyp and nkcsgexi January 19, 2022 00:34
@zoecarver
Copy link
Contributor Author

@swift-ci please test.

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - ce85f9da8ebe27625ab06d6c1cb945dbe9fb660d

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - ce85f9da8ebe27625ab06d6c1cb945dbe9fb660d

@zoecarver zoecarver force-pushed the re-land-nested-namespace-fix branch from ce85f9d to cead6ca Compare January 19, 2022 05:15
@zoecarver
Copy link
Contributor Author

@swift-ci please smoke test.

@zoecarver
Copy link
Contributor Author

@swift-ci please test.

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - cead6ca46c742dd567a63103757ce761a50d8596

@zoecarver
Copy link
Contributor Author

@swift-ci please test.

@zoecarver zoecarver force-pushed the re-land-nested-namespace-fix branch from cead6ca to bb6c2ae Compare January 19, 2022 18:57
@zoecarver
Copy link
Contributor Author

@swift-ci please test.

…sted namespaces across modules.

No one should be using C++ interop yet, so this part of the change cannot break anyone.
@zoecarver zoecarver force-pushed the re-land-nested-namespace-fix branch from bb6c2ae to 76e2934 Compare January 19, 2022 20:20
@zoecarver
Copy link
Contributor Author

@swift-ci please test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants