Run non-actor-isolated async functions on the generic executor #40910
Conversation
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
rjmccall
force-pushed
the
hop-to-generic-executor
branch
from
d3f9cea to
bbd4752
Compare
|
@swift-ci Please test |
rjmccall
changed the title
|
Build failed |
|
Build failed |
rjmccall
force-pushed
the
hop-to-generic-executor
branch
from
bbd4752 to
668d16c
Compare
rjmccall
changed the title
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
rjmccall
force-pushed
the
hop-to-generic-executor
branch
from
668d16c to
d0bdd03
Compare
|
@swift-ci Please test |
Async functions are now expected to set ExpectedExecutor in their prologue (and, generally, immediately hop to it). I updated the prologue code for a bunch of function emission, most of which was uninteresting. Top-level code was not returning to the main executor, which is now fixed; fortunately, we weren't assuming that we were on the main executor yet. We had some code that only kicked in when an ExpectedExecutor wasn't set which made us capture the current executor before a hop and then return to it later. This code has been removed; there's no situation in which save-and-return is the semantically correct thing to do given the possibility of hop optimization. I suspect it could also have led to crashes if the current executor is being kept alive only because it's currently running code. If we ever add async functions that are supposed to inherit their caller's executor, we should have the caller pass the right executor down to it. This is the first half of SE-0338; the second, sendability enforcement, is much more complicated, and Doug has volunteered to do it. Fixes rdar://79284465, as well as some tests that were XFAILed on Windows.
rjmccall
force-pushed
the
hop-to-generic-executor
branch
from
d0bdd03 to
716f4b9
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
@swift-ci Please test Linux |
|
Please test with following pull request: @swift-ci Please test macOS |
Fixes rdar://79284465