Skip to content

LoadableByAddress: Fix code that changes lowered return type of function. #40920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jckarter
Copy link
Contributor

It confused the original type's substituted generic signature for the new
type's invocation generic signature, leading to corrupted SIL when a
function had a substituted SIL function type with a return type involving
large loadable types that have to be passed indirectly in IR.

Fixes rdar://87792152

…ion.

It confused the original type's substituted generic signature for the new
type's invocation generic signature, leading to corrupted SIL when a
function had a substituted SIL function type with a return type involving
large loadable types that have to be passed indirectly in IR.

Fixes rdar://87792152
@jckarter jckarter requested a review from slavapestov January 19, 2022 23:32
@jckarter
Copy link
Contributor Author

@swift-ci Please test

Copy link
Contributor

@slavapestov slavapestov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you get a minute can you cherry-pick this into 5.6 as well?

@jckarter jckarter merged commit 840316a into swiftlang:main Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants