[5.6] LoadableByAddress: Fix code that changes lowered return type of function. #40930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion. It confused the original type's substituted generic signature for the new type's invocation generic signature, leading to corrupted SIL when a function had a substituted SIL function type with a return type involving large loadable types that have to be passed indirectly in IR. Fixes rdar://87792152
|
@swift-ci Please test |
|
@swift-ci Please nominate |
tbkka
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Functions using opaque return types, with large value types as arguments or returns, could end up causing invalid SIL to be generated, leading to compiler crashes.
Scope: Bug fix
Issue: rdar://87792152
Risk: Low. One-line fix for a specific edge case that was mishandled.
Testing: Swift CI, project from original issue
Reviewed by: @slavapestov