Opaque type fixes for interesting generic environments #40938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are same-type constraints involving opaque archetype parameters and generic parameters of the enclosing environment, a nested type of an opaque type archetype might in fact refer to something in the outer environment of the opaque type. Recognize this case and perform substitutions on such types using the opaque type's substitutions.
Use the same logic as we do for forming the opaque type result descriptor, of course.
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a few remaining issues with opaque result types that have "interesting" generic environments:
Although the tests here are described in terms of named opaque result types (which is hidden behind an experimental flag), the fixes also apply to structural opaque result types and any feature that allows us to add constraints to opaque result types.