Skip to content

Remove a ClangImporter function that I noticed is no longer in use. #4094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2016
Merged

Remove a ClangImporter function that I noticed is no longer in use. #4094

merged 1 commit into from
Aug 8, 2016

Conversation

rudkx
Copy link
Contributor

@rudkx rudkx commented Aug 8, 2016

What's in this pull request?

Remove a ClangImporter function that I noticed is no longer in use.


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform Comment
All supported platforms @swift-ci Please smoke test
All supported platforms @swift-ci Please smoke test and merge
OS X platform @swift-ci Please smoke test OS X platform
Linux platform @swift-ci Please smoke test Linux platform

A smoke test on macOS does the following:

  1. Builds the compiler incrementally.
  2. Builds the standard library only for macOS. Simulator standard libraries and
    device standard libraries are not built.
  3. lldb is not built.
  4. The test and validation-test targets are run only for macOS. The optimized
    version of these tests are not run.

A smoke test on Linux does the following:

  1. Builds the compiler incrementally.
  2. Builds the standard library incrementally.
  3. lldb is built incrementally.
  4. The swift test and validation-test targets are run. The optimized version of these
    tests are not run.
  5. lldb is tested.

Validation Testing

Platform Comment
All supported platforms @swift-ci Please test
All supported platforms @swift-ci Please test and merge
OS X platform @swift-ci Please test OS X platform
OS X platform @swift-ci Please benchmark
Linux platform @swift-ci Please test Linux platform

Lint Testing

Language Comment
Python @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

@rudkx rudkx self-assigned this Aug 8, 2016
@rudkx
Copy link
Contributor Author

rudkx commented Aug 8, 2016

@swift-ci Smoke test and merge.

@rudkx
Copy link
Contributor Author

rudkx commented Aug 8, 2016

The Linux failure looks like a problem with the builder.

@rudkx
Copy link
Contributor Author

rudkx commented Aug 8, 2016

@swift-ci Smoke test Linux and merge.

@rudkx
Copy link
Contributor Author

rudkx commented Aug 8, 2016

@swift-ci Smoke test and merge.

@rudkx
Copy link
Contributor Author

rudkx commented Aug 8, 2016

@tkremenek The linux test failed as a result of what looks like a builder configuration problem. This is just deleting an unused method and can be merged.

@tkremenek tkremenek merged commit 7f61956 into swiftlang:master Aug 8, 2016
@rudkx rudkx deleted the remove-dead-code branch August 8, 2016 21:49
kateinoigakukun pushed a commit that referenced this pull request Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants