-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[interop][SwiftToC++] print C++ interface for top-level Swift functions #40995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
fcdcb2a
[interop][SwiftToC++] print C++ interface for top-level Swift functions
hyp 1d3b682
[interop][SwiftToC++] fix execution tests to hopefully link correctly…
hyp 846fdb5
[interop] add target-build-swift-link-cxx option for windows to link …
hyp 07a1f56
[interop] add target-interop-clangxx test expansion to build C++ file…
hyp ebcf2f7
[interop] fixup the interop build test substitutions
hyp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
//===--- CxxSynthesis.cpp - Rules for synthesizing C++ code -----*- C++ -*-===// | ||
// | ||
// This source file is part of the Swift.org open source project | ||
// | ||
// Copyright (c) 2014 - 2022 Apple Inc. and the Swift project authors | ||
// Licensed under Apache License v2.0 with Runtime Library Exception | ||
// | ||
// See https://swift.org/LICENSE.txt for license information | ||
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
#include "CxxSynthesis.h" | ||
|
||
using namespace swift; | ||
using namespace cxx_synthesis; | ||
|
||
StringRef cxx_synthesis::getCxxImplNamespaceName() { return "_impl"; } | ||
|
||
/// Print a C++ namespace declaration with the give name and body. | ||
void CxxPrinter::printNamespace( | ||
llvm::function_ref<void(raw_ostream &OS)> namePrinter, | ||
llvm::function_ref<void(raw_ostream &OS)> bodyPrinter) const { | ||
os << "namespace "; | ||
namePrinter(os); | ||
os << " {\n\n"; | ||
bodyPrinter(os); | ||
os << "\n} // namespace "; | ||
namePrinter(os); | ||
os << "\n\n"; | ||
} | ||
|
||
void CxxPrinter::printNamespace( | ||
StringRef name, | ||
llvm::function_ref<void(raw_ostream &OS)> bodyPrinter) const { | ||
printNamespace([&](raw_ostream &os) { os << name; }, bodyPrinter); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
//===--- CxxSynthesis.h - Rules for synthesizing C++ code -------*- C++ -*-===// | ||
// | ||
// This source file is part of the Swift.org open source project | ||
// | ||
// Copyright (c) 2014 - 2022 Apple Inc. and the Swift project authors | ||
// Licensed under Apache License v2.0 with Runtime Library Exception | ||
// | ||
// See https://swift.org/LICENSE.txt for license information | ||
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
#ifndef SWIFT_PRINTASCLANG_CXXSYNTHESIS_H | ||
#define SWIFT_PRINTASCLANG_CXXSYNTHESIS_H | ||
|
||
#include "swift/Basic/LLVM.h" | ||
#include "llvm/ADT/StringRef.h" | ||
#include "llvm/Support/raw_ostream.h" | ||
|
||
namespace swift { | ||
|
||
namespace cxx_synthesis { | ||
|
||
/// Return the name of the implementation namespace that is used to hide | ||
/// declarations from the namespace that corresponds to the imported Swift | ||
/// module in C++. | ||
StringRef getCxxImplNamespaceName(); | ||
|
||
class CxxPrinter { | ||
public: | ||
CxxPrinter(raw_ostream &os) : os(os) {} | ||
|
||
/// Print a C++ namespace declaration with the give name and body. | ||
void | ||
printNamespace(llvm::function_ref<void(raw_ostream &OS)> namePrinter, | ||
llvm::function_ref<void(raw_ostream &OS)> bodyPrinter) const; | ||
|
||
void | ||
printNamespace(StringRef name, | ||
llvm::function_ref<void(raw_ostream &OS)> bodyPrinter) const; | ||
|
||
private: | ||
raw_ostream &os; | ||
}; | ||
|
||
} // end namespace cxx_synthesis | ||
} // end namespace swift | ||
|
||
#endif |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there's anything wrong with this, but usually, there'd be some object which we put all these functions in. Maybe
Implementation
?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I can pull it into an object class.