Specify the segment name that contains the reflection sections. #41021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
kastiglione
reviewed
Jan 26, 2022
include/swift/ABI/ObjectFile.h
Outdated
| @@ -28,6 +28,9 @@ class SwiftObjectFileFormat { | |||
| public: | |||
| virtual ~SwiftObjectFileFormat() {} | |||
| virtual llvm::StringRef getSectionName(ReflectionSectionKind section) = 0; | |||
| virtual llvm::Optional<llvm::StringRef> getContainingSegmentName() { | |||
There was a problem hiding this comment.
I think it would be fine to name this getSegmentName
augusto2112
force-pushed
the
reflection-segment-name
branch
from
6ffed2b to
6e088c3
Compare
|
@swift-ci smoke test |
adrian-prantl
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify the segment name that contains the reflection sections in different object file formats.