Skip to content

Rename @_predatesConcurrency to @preconcurrency. #41022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DougGregor
Copy link
Member

@DougGregor DougGregor commented Jan 26, 2022

Explanation: Makes the implementation of SE-0337 "Incremental Migration to Concurrency Checking a public feature by renaming @_predatesConcurrency to @preconcurrency.
Scope: New feature for Swift Concurrency that recently completed evolution review (but was otherwise already implemented).
Radar/SR Issue: rdar://86811401
Risk: Low.
Testing: PR testing and CI .
Original PR: #40680

Introduce the `@preconcurrency` attribute name for `@_predatesConcurrency`,
which has been the favored name in the pitch thread so far. Retain the
old name for now to help smooth migration.
@DougGregor DougGregor requested a review from a team as a code owner January 26, 2022 16:34
@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor
Copy link
Member Author

@swift-ci please test macOS

@DougGregor
Copy link
Member Author

@swift-ci please nominate

@DougGregor DougGregor merged commit d430b3e into swiftlang:release/5.6 Jan 28, 2022
@DougGregor DougGregor deleted the preconcurrency-attr-5.6 branch January 28, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants