[API notes] CTFontManagerError is not a valid Error at this time. #4104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoreText is below Foundation in the framework stack, so its error enum uses a CFStringRef constant as its domain instead of an NSString. The importer doesn't know how to handle that yet, so for now, just don't import CTFontManagerError as a first-class error type. rdar://problem/27722004
|
@slavapestov Mind "reviewing"? (More looking for confirmation that my analysis makes sense and matches yours than the actual review, but I will put you down as reviewer when cherry-picking to swift-3.0-branch.) @swift-ci Please test OS X platform |
|
Looks good. Anything we want to change in the ClangImporter, for example assert or diagnose when this occurs? |
|
That's not a bad idea, but I think it's okay not to pull that part into the 3.0 branch. I'll clone the Radar to follow up on it later. |
|
(We definitely can't assert because users have no control over this.) |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Aug 8, 2016
…iftlang#4104) CoreText is below Foundation in the framework stack, so its error enum uses a CFStringRef constant as its domain instead of an NSString. The importer doesn't know how to handle that yet, so for now, just don't import CTFontManagerError as a first-class error type. rdar://problem/27722004 (cherry picked from commit 449f4e4)
phausler
pushed a commit
to phausler/swift
that referenced
this pull request
Aug 8, 2016
…iftlang#4104) CoreText is below Foundation in the framework stack, so its error enum uses a CFStringRef constant as its domain instead of an NSString. The importer doesn't know how to handle that yet, so for now, just don't import CTFontManagerError as a first-class error type. rdar://problem/27722004
kateinoigakukun
added a commit
that referenced
this pull request
Aug 31, 2022
Resolve conflicts with upstream `main`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CoreText is below Foundation in the framework stack, so its error enum uses a CFStringRef constant as its domain instead of an NSString. The importer doesn't know how to handle that yet, so for now, just don't import CTFontManagerError as a first-class error type.
rdar://problem/27722004
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
A smoke test on macOS does the following:
device standard libraries are not built.
version of these tests are not run.
A smoke test on Linux does the following:
tests are not run.
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.