Skip to content

[stdlib] Update platform versions for SwiftStdlib 5.6; define placeholders for SwiftStdlib 5.7 #41046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 29, 2022

Conversation

lorentey
Copy link
Member

@lorentey lorentey commented Jan 27, 2022

Set platform version numbers for SwiftStdlib 5.6 to match the SDK releases that shipped with Xcode 13.3 beta 1.

Define the SwiftStdlib 5.7 macro with placeholder version numbers, and update APIs that are currently scheduled to ship from the main branch to use this instead of the generic SwiftStdlib 9999.

rdar://88154764

Also update existing declarations with SwiftStdlib 9999 availability to use the 5.7 name.
@lorentey lorentey force-pushed the define-stdlib-version-5.7 branch from 91272f4 to 61268aa Compare January 27, 2022 22:41
@lorentey
Copy link
Member Author

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 61268aa

@lorentey
Copy link
Member Author

--- /Users/buildnode/jenkins/workspace/swift-PR-macos/branch-main/swift/test/api-digester/Outputs/cake.json	2022-01-27 14:45:11.000000000 -0800
+++ /Users/buildnode/jenkins/workspace/swift-PR-macos/branch-main/buildbot_incremental/swift-macosx-x86_64/test-macosx-x86_64/api-digester/Output/dump-module.swift.tmp.dump.json	2022-01-27 16:59:22.000000000 -0800
@@ -1713,8 +1713,7 @@
           "name": "CodingKeyRepresentable",
           "printedName": "CodingKeyRepresentable",
           "usr": "s:s22CodingKeyRepresentableP",
-          "mangledName": "$ss22CodingKeyRepresentableP",
-          "isABIPlaceholder": true
+          "mangledName": "$ss22CodingKeyRepresentableP"
         },
         {
           "kind": "Conformance",

--

This may be a related failure.

@lorentey
Copy link
Member Author

/Users/buildnode/jenkins/workspace/swift-PR-macos/branch-main/swift/test/Sanitizers/tsan/racy_async_let_fibonacci.swift:70:11: error: CHECK: expected string not found in input
// CHECK: ThreadSanitizer: Swift access race
          ^

This is definitely unrelated.

@lorentey
Copy link
Member Author

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - d94ed862902855d626d78ce3a6eaaf1681657364

@benrimmington
Copy link
Contributor

You may need to update cake.json and cake-abi.json as well.

@lorentey lorentey force-pushed the define-stdlib-version-5.7 branch from d94ed86 to f36a72e Compare January 29, 2022 00:55
@lorentey
Copy link
Member Author

@swift-ci test

@lorentey lorentey merged commit 63b752e into swiftlang:main Jan 29, 2022
@lorentey lorentey deleted the define-stdlib-version-5.7 branch January 29, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants