Skip to content

[Distributed] Introduce "roundtrip" test and AS, remove duplication and cleanups #41056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 28, 2022

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Jan 28, 2022

Followup to introduction of remote calls.

Introduces "roundtrip" tests and does a lot of cleanups.

  • move func "getters" to ASTContext
  • introduce reusable "roundtrip actor system"
  • introduce "roundtrip" test

Will add more commit by commit.

@ktoso ktoso requested a review from xedin January 28, 2022 11:12
@ktoso ktoso added the distributed Feature → concurrency: distributed actor label Jan 28, 2022
@ktoso
Copy link
Contributor Author

ktoso commented Jan 28, 2022

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit 3e228bd into swiftlang:main Jan 28, 2022
try await executeDistributedTarget(
on: active,
mangledTargetName: target.mangledName,
invocationDecoder: &invocation,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI - I'm dropping inout in my upcoming PR.


}

public struct FakeRoundtripInvocation: DistributedTargetInvocationEncoder, DistributedTargetInvocationDecoder {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be a class.

Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distributed Feature → concurrency: distributed actor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants