Support file compilation dir #41062
Merged
Support file compilation dir #41062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Implement the logic: Configure DebugCompilationDir with the path specified by the flag, otherwise with current working directory. 3. Add test case for mac, linux and windows
pofat
force-pushed
the
support_flag_file_compilation_dir
branch
from
a847cef to
bee2312
Compare
|
hello @adrian-prantl @kastiglione , I hope this can be merged into Swift 5.6 branch. What's the process to request approval? Thank you. |
|
I believe the 5.6 branch is only accepting bug fixes at this point. |
|
I'm going to discuss this with the swift5-branch-maintainers. It's possible that the answer is going to be no, since only bugfixes should be merged into 5.6 at this point. |
|
@swift-ci nominate |
|
@swift-ci test |
DougGregor
approved these changes
Feb 2, 2022
|
Thank you very much! @adrian-prantl @DougGregor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original PR is merged to main.
In short, this flag gives us identical debug info paths regardless of what location we compiled the file from.
It's a small but useful feature, and hope it can happen on Swift 5.6.
Resolves SR-5694.