Fix incorrect scopes of variables declared in guard let statements (again) #41069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-prantl
requested review from
slavapestov,
DougGregor and
airspeedswift
|
@swift-ci test |
|
@swift-ci nominate |
tkremenek
approved these changes
Jan 28, 2022
|
Build failed |
This leads to an assertion failure in IRGen. A `guard let foo = foo` statement needs to introduce a new lexical scope so the newely introduced binding can be distinguished from the one it shadows. rdar://86579287
adrian-prantl
force-pushed
the
86579287-5.6
branch
from
a418748 to
d931c20
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leads to an assertion failure in IRGen. A
guard let foo = foostatementneeds to introduce a new lexical scope so the newely introduced binding can be
distinguished from the one it shadows.
rdar://86579287