[5.6] Look through defer bodies in actor isolation checking #41077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please test with pull request: @swift-ci Please test |
DougGregor
approved these changes
Jan 28, 2022
|
Build failed |
|
Build failed |
rjmccall
force-pushed
the
defer-isolation-5.6
branch
from
6f26774 to
62a58ed
Compare
|
@swift-ci Please test |
Fixes rdar://88200899
|
Build failed |
rjmccall
force-pushed
the
defer-isolation-5.6
branch
from
62a58ed to
169167e
Compare
|
@swift-ci Please test |
|
This still seems to be an issue in Swift 5.6: https://forums.swift.org/t/a-bug-cant-defer-actor-isolated-variable-access/50796 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://88200899
5.6 version of #41067
Explanation: The isolation checker wasn't treating defer bodies as having the same isolation as the enclosing function, meaning that you couldn't e.g. access actor properties from a
deferin an actor or call@MainActorfunctions in adeferin a@MainActorfunction.Scope: New code paths are guarded by checks for defer blocks. Emits strictly fewer diagnostics.
Risk: Low
Testing: Existing regression tests, new test specific to
deferReviewers: @DougGregor, @kavon