[Distributed] Augment distributed accessor to lookup witness tables for decode call #41101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d serialization requirements A proper `decodeNextArgument` candidate should cover all of the protocols listed in `SerializationRequirement` associated with distributed actor it would be used for.
…code call `decodeNextArgument` requires (at least) that argument type conform to a serialization requirement, witness table(s) for all protocol requirements have to be lookup up by accessor to form correct `decodeNextArgument` invocation.
It's an ad-hoc requirement that has to be checked by the compiler, since it requires knowledge about a concrete serialization requirement type associated with a particular distributed actor system.
|
@swift-ci please test |
ktoso
approved these changes
Jan 31, 2022
| actor, ctx.Id_SerializationRequirement) | ||
| ->castTo<ExistentialType>() | ||
| ->getConstraintType() | ||
| ->getDesugaredType(); |
There was a problem hiding this comment.
Oh I see, totally would have missed that last two calls
xedin
force-pushed
the
load-witness-tables-for-decodeNextArgument
branch
from
99cb041 to
9694597
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decodeNextArgumentrequires (at least) that argument type conformto a serialization requirement, witness table(s) for all protocol
requirements have to be lookup up by accessor to form correct
decodeNextArgumentinvocation.