Skip to content

🍒 [5.6] Remove Task.CancellationError in doc comments #41107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Jan 31, 2022

Description: Task.CancellationError has been renamed to CancellationError. Fix two doc comments that still used the old name.
Risk: Low
Review by: @amartini51 @kavon
Testing: CI validation
Original PR: #41097
Radar: rdar://88292687

Task.CancellationError has been renamed to CancellationError. Fix two doc comments that still used the old name.
@ktoso ktoso requested a review from a team as a code owner January 31, 2022 21:56
@ktoso
Copy link
Contributor Author

ktoso commented Jan 31, 2022

@swift-ci please test

@ktoso ktoso changed the title Remove Task.CancellationError in doc comments 🍒 [5.6] Remove Task.CancellationError in doc comments Jan 31, 2022
@ktoso ktoso added the r5.6 label Jan 31, 2022
Copy link
Member

@kavon kavon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@amartini51 amartini51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks for doing the cherry pick

@ktoso
Copy link
Contributor Author

ktoso commented Feb 1, 2022

@swift-ci please nominate

@ktoso
Copy link
Contributor Author

ktoso commented Feb 1, 2022

Gladly @amartini51 , thanks for review!

@tkremenek tkremenek merged commit a33eaf6 into swiftlang:release/5.6 Feb 1, 2022
@ktoso ktoso deleted the pick-cancellationerror-doccomments branch February 1, 2022 21:59
@AnthonyLatsis AnthonyLatsis added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.6 labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants