[5.6][CSApply] Result coercion check should always use resolved type #41109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`shouldCoerceToContextualType` used `solution.getType(ASTNode)` which returns a type that has type variables in it. To properly check whether result type needs a coercion it has to be resolved first which is done via `solution.getResultType(ASTNode)`. Resolves: rdar://88285682 (cherry picked from commit 48ffedd)
|
@swift-ci please test |
DougGregor
approved these changes
Feb 1, 2022
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #41108
Fix a crash when function body consists of a single expression that returns
Neverfrom a method call on overloaded base.
shouldCoerceToContextualTypeusedsolution.getType(ASTNode)which returns a type that has type variables in it. To properly
check whether result type needs a coercion it has to be resolved
first which is done via
solution.getResultType(ASTNode).Scope: Single-expression function bodies where method call returns
Neveron overloaded base type.Main Branch PR: [CSApply] Result coercion check should always use resolved type #41108
Resolves: rdar://88285682
Risk: Very low
Reviewed By: @hborla
Testing: Added a regression test-case to the suite.
Resolves: rdar://88285682
(cherry picked from commit 48ffedd)