Skip to content

Use rsync for remote-run. #41125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2022
Merged

Conversation

al45tair
Copy link
Contributor

@al45tair al45tair commented Feb 1, 2022

Not only does this give us a huge speed-up, it also works around a problem where sftp doesn't always update the modification time, which causes random test failures.

rdar://88179140

@al45tair
Copy link
Contributor Author

al45tair commented Feb 1, 2022

@swift-ci Please test

@al45tair
Copy link
Contributor Author

al45tair commented Feb 1, 2022

@swift-ci Please smoke test

@al45tair
Copy link
Contributor Author

al45tair commented Feb 1, 2022

@swift-ci Please test

@al45tair
Copy link
Contributor Author

al45tair commented Feb 1, 2022

@swift-ci Please smoke test

Copy link
Contributor

@mikeash mikeash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it.

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda sad that this makes remote testing more challenging for Windows, but given that isn't in use right now ... we can deal with that later.

@swift-ci
Copy link
Contributor

swift-ci commented Feb 1, 2022

Build failed
Swift Test Linux Platform
Git Sha - 738cebf3fd9d3dc61f559e1caf271a1266b5d975

Not only does this give us a huge speed-up, it also works around a problem
where sftp doesn't always update the modification time, which causes random
test failures.

rdar://88179140
@al45tair al45tair force-pushed the eng/PR-88179140.rsync branch from 738cebf to 2f6f051 Compare February 1, 2022 19:21
@al45tair
Copy link
Contributor Author

al45tair commented Feb 1, 2022

:-D Would have helped if I'd checked in the lit.local.cfg.

@swift-ci Please smoke test

@al45tair
Copy link
Contributor Author

al45tair commented Feb 1, 2022

@swift-ci Please test

@al45tair
Copy link
Contributor Author

al45tair commented Feb 1, 2022

Kinda sad that this makes remote testing more challenging for Windows, but given that isn't in use right now ... we can deal with that later.

There are Windows versions of rsync, so hopefully this isn't an insurmountable problem.

@compnerd
Copy link
Member

compnerd commented Feb 1, 2022

@swift-ci please test Windows platform

@swift-ci
Copy link
Contributor

swift-ci commented Feb 2, 2022

Build failed
Swift Test OS X Platform
Git Sha - 2f6f051

@al45tair
Copy link
Contributor Author

al45tair commented Feb 2, 2022

@swift-ci Please test macOS platform

@al45tair al45tair merged commit 6c23d92 into swiftlang:main Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants