[5.6][SE-0309] Disable SE-0309 in Swift 5.6. #41131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…universal-existentials, and disable the flag by default.
|
@swift-ci please clean test |
|
Thanks! I imagined this was going to be more of a pain in one place but then you just gated it behind a flag 😅 |
|
@AnthonyLatsis it was pretty convenient that I happened to already put the code that identifies SE-0309 existentials back for SE-0335 😆 |
|
@swift-ci please test |
DougGregor
approved these changes
Feb 2, 2022
airspeedswift
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selfor associated type requirements as existential types. This feature is not fully implemented; one of the missing pieces from the proposal in Swift 5.6 is covariant erasure for dependent-member types, which allows calling the APIs that useSelfor associated type in covariant position on the existential type. Without this functionality, the API surface on SE-0309 existentials is fairly limited, and leads to confusing error messages when attempting to call APIs that should be available via covariant erasure. This change adds a frontend flag-enable-experimental-universal-existentialsfor SE-0309, and disables the feature by default. This change also disables building the experimental _Distributed library by default, because it adopts SE-0309 (in code that no longer exists on themainbranch).-enable-experimental-universal-existentialsflag to several existing tests that make use of SE-0309.