[SymbolGraph] don't filter out all implicit decls #41141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm posting this as a draft until i can get a test case written. In the meantime, i'm going to build a toolchain for manual testing: @swift-ci Please build toolchain macOS platform |
|
macOS Toolchain Install command |
QuietMisdreavus
force-pushed
the
QuietMisdreavus/symgraph-synth-init
branch
from
31a81b5 to
52cf515
Compare
|
@swift-ci Please smoke test |
franklinsch
reviewed
Feb 2, 2022
franklinsch
approved these changes
Feb 2, 2022
QuietMisdreavus
force-pushed
the
QuietMisdreavus/symgraph-synth-init
branch
from
52cf515 to
08fe7c2
Compare
|
@swift-ci Please smoke test |
QuietMisdreavus
changed the title
QuietMisdreavus
added a commit
that referenced
this pull request
Mar 23, 2022
currently, we only create synthesied USRs for symbols that appear in an extension block. this can fail to catch implicitly-inherited symbols in other situations. now that we emit implicit constructor decls (see #41141), this can create situations where different symbols get the same USR. this commit ensures that these implicit constructors are given synthesized USRs, so that they don't clash with their upstream symbol. rdar://90401347
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves rdar://86294494
When generating a symbol graph with minimum-access-level set to
internal, implicitly-generated initializers are not included in the symbol graph, despite being available at that access level. This PR removes the filter in SymbolGraphGen that removes all implicit decls; most of them are being filtered in SourceEntityWalker anyway, so removing this check is harmless for the purposes of the symbol graph.