Skip to content

[5.6][SymbolGraph] don't filter out all implicit decls #41167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2022
Merged

[5.6][SymbolGraph] don't filter out all implicit decls #41167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions lib/SymbolGraphGen/SymbolGraph.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -655,10 +655,6 @@ bool SymbolGraph::canIncludeDeclAsNode(const Decl *D) const {
return false;
}

if (D->isImplicit()) {
return false;
}

if (!isa<ValueDecl>(D)) {
return false;
}
Expand Down
22 changes: 22 additions & 0 deletions test/SymbolGraph/Symbols/Implicit.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
// RUN: %empty-directory(%t)
// RUN: %target-build-swift %s -module-name Implicit -emit-module -emit-module-path %t/
// RUN: %target-swift-symbolgraph-extract -module-name Implicit -I %t -pretty-print -output-dir %t -minimum-access-level internal
// RUN: %FileCheck %s --input-file %t/Implicit.symbols.json

// RUN: %target-swift-symbolgraph-extract -module-name Implicit -I %t -pretty-print -output-dir %t
// RUN: %FileCheck %s --input-file %t/Implicit.symbols.json --check-prefix PUBLIC

public class SomeClass {}

public struct SomeStruct {
let bar: Int
let other: String
}

// make sure that the implicitly-generated initializer appears when the access level is `internal`
// CHECK-DAG: "precise": "s:8Implicit9SomeClassCACycfc"
// CHECK-DAG: "precise": "s:8Implicit10SomeStructV3bar5otherACSi_SStcfc"

// ...but that they don't show up when it's `public`, since they're marked `internal` to begin with
// PUBLIC-NOT: "precise": "s:8Implicit9SomeClassCACycfc"
// PUBLIC-NOT: "precise": "s:8Implicit10SomeStructV3bar5otherACSi_SStcfc"