constant_vprintf: Add a mode where prints are silenced when -DPRINT_DISABLED is present on the client side #41177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ISABLED is present on the client side
|
@swift-ci please test |
kubamracek
commented
Feb 4, 2022
| @_optimize(none) | ||
| public func constant_vprintf(_ message: ConstantVPrintFMessage) { | ||
| let formatString = message.interpolation.formatString | ||
| let argumentClosures = message.interpolation.arguments.argumentClosures | ||
| if Bool(_builtinBooleanLiteral: Builtin.ifdef_PRINT_DISABLED()) { return } |
There was a problem hiding this comment.
Maybe let me just explain why this isn't the very 1st line in the function: If I put it into the 1st line, the copy-propagation + constant-folding + dead-code-elimination doesn't like that, because it for some reason isn't able to fully eliminate the ConstantVPrintFMessage input. I haven't fully investigated why, but placing the check as the 3rd line (after all accesses to "message") seems to work as a simple workaround.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a test that showcases that this actually works.