Fix SILOptimizer crash for top-level async code #41187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lowering hops to actors expected the executor to either be an optional
builtin executor type or an actor type. The type coming from
`getMainExecutor` is just a builtin executor, not an optional. As a
result, `LowerHopToActor::emitGetExecutor` would get called in
`LowerHopToActor::processHop`, and would try looking up the builtin
executor type, thinking it was an actor type. This would fail because we
didn't have an actor type.
```
auto actorConf = module->lookupConformance(actorType, actorProtocol);
assert(actorConf &&
"hop_to_executor with actor that doesn't conform to Actor");
```
The end result was hitting this assert here, saying that the "actor"
doesn't conform to actor.
The fix is to wrap the executor in an optional.
etcwilde
added
the
concurrency
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lowering hops to actors expected the executor to either be an optional
builtin executor type or an actor type. The type coming from
getMainExecutoris just a builtin executor, not an optional. As aresult,
LowerHopToActor::emitGetExecutorwould get called inLowerHopToActor::processHop, and would try looking up the builtinexecutor type, thinking it was an actor type. This would fail because we
didn't have an actor type.
The end result was hitting this assert here, saying that the "actor"
doesn't conform to actor.
The fix is to wrap the executor in an optional.