[Reflection] Fix failing arm64e test #41196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdar://88403538
|
@swift-ci smoke test |
al45tair
reviewed
Feb 4, 2022
| @@ -421,7 +421,8 @@ class MetadataReader { | |||
| } | |||
| } else { | |||
| resolved = Reader->resolvePointer(RemoteAddress(remoteAddress), 0); | |||
| if (!resolved) | |||
| if (resolved.getSymbol().empty()) | |||
There was a problem hiding this comment.
Nit: I'd add braces here. I know technically it doesn't need it, because it's still only followed by a single statement, but still.
augusto2112
approved these changes
Feb 4, 2022
al45tair
approved these changes
Feb 4, 2022
|
@swift-ci smoke test |
kastiglione
added a commit
that referenced
this pull request
Feb 4, 2022
[Reflection] Fix failing arm64e test (cherry picked from commit 5a5f4b0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://88403538
Fixes an issue created by #41087.