Enable RequirementMachine for the standard library's protocol signatures #41200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esult over the GSB
|
@swift-ci Please smoke test |
This was only passing before because -requirement-machine-protocol-signatures=verify only checked conformance requirements, and it would return the GSB's result if there was a mismatch. It actually never did the right thing with the Requirement Machine. Disable it until rdar://problem/88135912 is fixed.
Fixes rdar://problem/46313629.
slavapestov
force-pushed
the
enable-rqm-protocols-for-stdlib
branch
from
67b4489 to
76571c7
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will give us some more test coverage in CI, and fix the bogus requirement signatures in the Collection and StringProtocol protocols as a nice side effect.
Fixes rdar://problem/46313629.