Skip to content

Move a few lines from stability-stdlib-abi-with-asserts.test to stability-stdlib-abi-without-asserts.test #41247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

slavapestov
Copy link
Contributor

No description provided.

@slavapestov slavapestov requested a review from glessard February 7, 2022 17:53
@slavapestov
Copy link
Contributor Author

@glessard This was failing in the noasserts bots. It appears the change is independent of asserts vs noasserts, and should go in the noasserts diff instead (which is concatenated with the asserts diff).

@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@glessard
Copy link
Contributor

glessard commented Feb 7, 2022

I initially tried to add it to the no-asserts exclusion list, and it still failed. That's why I added it to the with-asserts file instead.

@slavapestov
Copy link
Contributor Author

https://ci.swift.org/job/oss-swift_tools-R_stdlib-RD_test-simulator//6876/consoleFull

Copy link
Contributor

@glessard glessard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slavapestov slavapestov merged commit 790a79e into swiftlang:main Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants