[Regex] Switch regex match to Swift tuples. #41275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxwei
force-pushed
the
regex-update-dev-6
branch
2 times, most recently
from
bcac635 to
9cf9ec7
Compare
milseman
reviewed
Feb 8, 2022
| @@ -10,41 +10,39 @@ takesRegex('//') // okay | |||
| let r1 = '/.(.)/' | |||
| // Note: We test its type with a separate statement so that we know the type | |||
| // checker inferred the regex's type independently without contextual types. | |||
| let _: Regex<Tuple2<Substring, Substring>>.Type = type(of: r1) | |||
| let _: Regex<(Substring, Substring)>.Type = type(of: r1) | |||
There was a problem hiding this comment.
For someone to pick up these test changes as fixes instead of failures, would they need to run update-checkout, or are the tests versioned by tag?
There was a problem hiding this comment.
They would need to update-checkout and re-run build-script.
|
@swift-ci please test |
rxwei
force-pushed
the
regex-update-dev-6
branch
from
9cf9ec7 to
c5e45dc
Compare
|
@swift-ci please test |
rintaro
approved these changes
Feb 9, 2022
rxwei
force-pushed
the
regex-update-dev-6
branch
from
c5e45dc to
7fd0e22
Compare
Typed captures no longer use ad-hoc nominal tuples. We use Swift native tuples instead. See swiftlang/swift-experimental-string-processing#127. Update checkout tag to dev/6.
rxwei
force-pushed
the
regex-update-dev-6
branch
from
7fd0e22 to
cf8e0fe
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
|
@swift-ci please test macOS |
|
Bumping the tag requires CI to be updated separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typed captures no longer use ad-hoc nominal tuples. We use Swift native tuples instead. See swiftlang/swift-experimental-string-processing#127.
Update checkout tag to dev/6.