RequirementMachine: Fix some trivial problems running validation tests with -requirement-machine-inferred-signatures=verify #41324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th protocol-qualified types
…ss and concrete type requirements In the long run it doesn't really matter if we leave them in there, but for now matching the GenericSignatureBuilder's behavior makes the tests pass with -requirement-machine-inferred-signatures=verify.
…of a GenericParamList These come up in SIL and in the experimental named opaque result types implementation. Pass the correct DeclContext here, instead of using the ModuleDecl.
|
@swift-ci Please smoke test |
|
@hborla The change to desugarConformanceRequirement() might impact your work slightly. |
… now type checks; move it to test/Generics/
If we call TypeRepr::setInvalid() we need to return an ErrorType, because we'll return an ErrorType if this same TypeRepr is resolved again. This just makes the RequirementMachine's behavior match the GenericSignatureBuilder on some highly-invalid compiler_crashers.
…tiableAttr We forgot to handle this case, which would lead to a crash.
slavapestov
force-pushed
the
rqm-trivial-validation-test-fixes
branch
from
8962105 to
1244b17
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test macOS |
1 similar comment
|
@swift-ci Please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes 33 out of 100 validation-test failures.