Skip to content

Use Swift.def to define enums and switch cases for swift5 reflection sections #41371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

rastogishubham
Copy link
Contributor

With 698e04780b5560bbe25dd87ecec77fc381afd770 a Swift.def file has been defined in llvm-project to make defining the different swift5 reflection sections easier.

This change just updates ObjectFile.h to use that .def file

@rastogishubham
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thank you.

@rastogishubham
Copy link
Contributor Author

@swift-ci please test

1 similar comment
@rastogishubham
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@adrian-prantl adrian-prantl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@rastogishubham
Copy link
Contributor Author

@swift-ci please test

1 similar comment
@rastogishubham
Copy link
Contributor Author

@swift-ci please test

@rastogishubham rastogishubham merged commit 83be9ba into swiftlang:main Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants