fix flow-isolation diagnostic message crash #41375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test and merge |
kavon
force-pushed
the
unsegfault-flowiso
branch
from
0c872ee to
027a292
Compare
|
@swift-ci please test |
slavapestov
reviewed
Feb 15, 2022
kavon
force-pushed
the
unsegfault-flowiso
branch
from
027a292 to
6301e16
Compare
|
@swift-ci please smoke test and merge |
When emitting the note to point out what introduced nonisolation, the code building the message assumed that `DeclContext::getDecl` will not return null, when it can if it's a closure expression. fixes rdar://88776902
kavon
force-pushed
the
unsegfault-flowiso
branch
from
6301e16 to
1343f6b
Compare
kavon
changed the title
|
I figured out what went wrong; the decl name was not it. @swift-ci please smoke test and merge |
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves rdar://88776902