[build-script] Don't hardcode macosx-x86_64 #414
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve FIXME by using `build_directory()` function.
|
@modocache Sorry, that's not correct when cross-compiling. To fix this FIXME, we need to add a notion of "current native tools" more broadly to the script. Also, if you are interested in working on the build script, another project is rewriting it in Python. |
|
Gotcha, thanks! Rewriting the build script in Python sounds interesting, but doing so might be biting off more than I can chew for a weekday night. 😉 |
slavapestov
pushed a commit
to slavapestov/swift
that referenced
this pull request
Nov 27, 2018
WIP/DNM: LLP64 support for SDK Overlay
kateinoigakukun
added a commit
to kateinoigakukun/swift
that referenced
this pull request
Mar 20, 2020
…nightly-dist Cronize nightly toolchain distribution
freak4pc
pushed a commit
to freak4pc/swift
that referenced
this pull request
Sep 28, 2022
[5.2] Add support for swift-5.2-branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve FIXME by using
build_directory()function.(The following isn't part of any commit message in this pull request.)
It seems like
utils/build-script-implcontains a lot of hardcoded references tomacosx-x86_64. I happened to find this one while looking at https://github.com/apple/swift/blob/91bfa8d0d5fb07cd143607798d3b6f33729d6547/test/lit.cfg#L173.If this is the right approach I'll send up more pull requests for the others--but let me know if the problem isn't as straightforward as I'm making it out to be.