Sema: Clean up name lookup and fix a couple of bugs #4143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
Previously, qualified lookup would use a metatype to signal to the LookupResultBuilder that conformance checks should not be used to resolve protocol members found with a concrete type base. This is too subtle for my taste. Add an explicit flag and clean up some usages, fixing <rdar://problem/16123805>. Also, clean up the 'CheckProtocolMembers' flag. We now set when the base type is an archetype, and correctly handle the concept of an abstract conformance. This finally fixes <rdar://problem/22776964>.
slavapestov
force-pushed
the
name-lookup-cleanup
branch
from
842791d to
d5c2f44
Compare
|
@swift-ci Please smoke test |
|
I feel like a "don't perform conformance checks" flag is a bit more than just a clean-up. Can you talk more about what this is doing and why it's safe? |
|
@jrose-apple The flag just makes the old behavior explicit where passing in a nominal type would allow conformance checks, but passing in a metatype would not. |
|
We don't want to do conformance checks when matching protocol witnesses for example, to avoid runaway recursion. However we do want witness lookup to consider protocol extension members. |
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.