-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[cxx-interop] Add support for operator! overloading #41434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cxx-interop] Add support for operator! overloading #41434
Conversation
Nice work Alex. :-) |
@swift-ci please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good. Thanks.
Actually, can you please also update the tests in |
9149b78
to
d09de50
Compare
Okay, I updated the PR. Here's the changelog:
Let me know if there's anything else you'd like to see changed. |
This looks great. Thanks again! |
I'll start the bots once you fix the Windows mangling. If you want me to run the bots so you can see the failure (it will print out the correct mangling) let me know and I can do that. |
Yes, if you could please trigger the bots to show me the Windows mangling that would be great! I don't have access to a windows machine currently. |
@swift-ci please test |
@zoecarver Could you trigger the test bots so I can get an idea of what the windows manglings will be? |
@swift-ci please smoke test |
d09de50
to
365f75d
Compare
Ok, got the test fixed up for windows. @drodriguez Can you trigger the tests again for me please? Thanks! |
@swift-ci please smoke test |
@zoecarver Think this is good to go in now? Or should we wait for the Linux Platform to be unborked? |
@swift-ci please test Linux platform |
This patch enables operator overloading for operator! when cxx interop is enabled. This is my first patch related to cxx interop, let me know if I should be doing something differently.
@plotfi @zoecarver @hyp