[Demangler] Make Node::addChild(NULL, ...) always assert. #41452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need this in order to gather relevant information when this situation arises; it's clearly happening (e.g. rdar://86071019), but not often enough for it to trigger in a build with assertions enabled. rdar://89139049
|
@swift-ci Please smoke test |
mikeash
approved these changes
Feb 18, 2022
|
@swift-ci Please smoke test |
Good plan. I've made the |
al45tair
force-pushed
the
eng/PR-89139049
branch
2 times, most recently
from
b7bd245 to
8bccf9d
Compare
This should help to debug things when things go wrong. rdar://89139049
al45tair
force-pushed
the
eng/PR-89139049
branch
from
8bccf9d to
e4855e7
Compare
|
@swift-ci Please smoke test |
mikeash
reviewed
Mar 11, 2022
al45tair
changed the title
I was trying to use fatalError() here, but that is in libswiftRuntime, which isn't linked into everything that has the demangler code in it. The upshot is that we'd have to touch a lot of other projects to use fatalError(). rdar://89139049
al45tair
force-pushed
the
eng/PR-89139049
branch
from
14edfe9 to
edbfce2
Compare
|
@swift-ci Please smoke test |
The demangling library can't use the error handling from the main runtime because it isn't always linked with it. However, it's useful to have some error handling, and in particular to be able to get data into the crash logs. This is complicated because of the way the demangling library gets used, the upshot of which is that I've had to add a second object library just for libswiftCore's use, so that the demangler will use the runtime's error handling functions when present, and fall back on its own when they aren't. rdar://89139049
|
@swift-ci Please smoke test |
al45tair
force-pushed
the
eng/PR-89139049
branch
from
f060c5b to
97b266f
Compare
|
@swift-ci Please smoke test |
Crash reporter integration was only enabled for iOS. Enable it for any Darwin platform, but disable it for the minimal build. Also fix up a couple of issues that popped up when it was enabled. rdar://89139049
al45tair
force-pushed
the
eng/PR-89139049
branch
from
97b266f to
b253705
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test |
al45tair
added a commit
to al45tair/swift
that referenced
this pull request
Mar 25, 2022
Some of the functions inside the SWIFT_STDLIB_HAS_TYPE_PRINTING conditional are now needed even in the minimal build as a result of swiftlang#41452. rdar://90839754
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need this in order to gather relevant information when this situation arises; it's clearly happening (e.g. rdar://86071019), but not often enough for it to trigger in a build with assertions enabled.
rdar://89139049