Skip to content

[SILOpt] Disabled DestroyHoisting. #41478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 18, 2022
Merged

[SILOpt] Disabled DestroyHoisting. #41478

merged 5 commits into from
Mar 18, 2022

Conversation

nate-chandler
Copy link
Contributor

No description provided.

@nate-chandler
Copy link
Contributor Author 

------- Performance (x86_64): -O -------

REGRESSION                                OLD     NEW     DELTA     RATIO
StringFromLongWholeSubstringGeneric       3       16      +433.2%   **0.19x**
StringFromLongWholeSubstring              2       8       +299.9%   **0.25x**
DataCreateEmptyArray                      850     1450    +70.6%    **0.59x**
DropWhileArrayLazy                        31      49      +58.1%    **0.63x (?)**
ObserverForwarderStruct                   685     1040    +51.8%    **0.66x (?)**
Set.isSuperset.Seq.Box0                   137     208     +51.8%    **0.66x**
DictionarySubscriptDefaultMutationArray   278     402     +44.6%    **0.69x (?)**
DataCountSmall                            15      19      +26.7%    **0.79x (?)**
DataCreateEmpty                           80      100     +25.0%    **0.80x (?)**
SortIntPyramid                            360     445     +23.6%    **0.81x (?)**
RemoveWhereFilterStrings                  298     367     +23.2%    **0.81x (?)**
RemoveWhereMoveStrings                    280     342     +22.1%    **0.82x (?)**
DataCreateSmallArray                      1750    2100    +20.0%    **0.83x (?)**
ParseInt.UIntSmall.Binary                 444     520     +17.1%    **0.85x (?)**
ProtocolConformance                       51      58      +13.7%    **0.88x (?)**
ReversedArray2                            97      110     +13.4%    **0.88x (?)**
DataCountMedium                           15      17      +13.3%    **0.88x**
ParseInt.IntSmall.UncommonRadix           312     352     +12.8%    **0.89x (?)**
ArrayAppendAscii                          1768    1972    +11.5%    **0.90x (?)**
AnyHashableWithAClass                     67000   74500   +11.2%    **0.90x (?)**
Dictionary3OfObjects                      344     381     +10.8%    **0.90x (?)**
SetSymmetricDifferenceBox25               296     327     +10.5%    **0.91x (?)**
ArrayAppendLatin1                         1802    1972    +9.4%     **0.91x (?)**
ArrayAppendUTF16                          1802    1972    +9.4%     **0.91x (?)**
SetSymmetricDifferenceBox0                427     467     +9.4%     **0.91x (?)**
DictionaryCompactMapValuesOfCastValue     4698    5130    +9.2%     **0.92x (?)**
DictionaryGroupOfObjects                  954     1035    +8.5%     **0.92x (?)**
String.replaceSubrange.RepChar.Small      312     337     +8.0%     **0.93x (?)**

IMPROVEMENT                               OLD     NEW     DELTA     RATIO
Data.append.Sequence.64kB.Count.RE        29      19      -34.5%    **1.53x**
Data.append.Sequence.64kB.Count.RE.I      29      20      -31.0%    **1.45x (?)**
FlattenListLoop                           1385    958     -30.8%    **1.45x (?)**
BinaryFloatingPointPropertiesUlp          26      19      -26.9%    **1.37x**
Set.subtracting.Empty.Box                 21      17      -19.0%    **1.24x**
DataAppendSequence                        6800    5600    -17.6%    **1.21x (?)**
Data.append.Sequence.809B.Count.RE.I      69      58      -15.9%    **1.19x (?)**
Data.append.Sequence.809B.Count.RE        68      58      -14.7%    **1.17x (?)**
ArrayAppendLazyMap                        1720    1480    -14.0%    **1.16x (?)**
Breadcrumbs.MutatedIdxToUTF16.Mixed       223     193     -13.5%    **1.16x (?)**
DataSubscriptSmall                        15      13      -13.3%    **1.15x**
Breadcrumbs.MutatedUTF16ToIdx.Mixed       218     189     -13.3%    **1.15x (?)**
ArrayLiteral2                             78      69      -11.5%    **1.13x (?)**
ParseFloat.Double.Exp                     9       8       -11.1%    **1.12x (?)**
Set.isDisjoint.Empty.Int                  88      79      -10.2%    **1.11x (?)**
Set.isSuperset.Seq.Int.Empty              88      80      -9.1%     **1.10x (?)**
Set.isDisjoint.Seq.Empty.Int              81      74      -8.6%     **1.09x (?)**
Set.isSubset.Seq.Empty.Int                81      74      -8.6%     **1.09x (?)**
SIMDRandomMask.Int8x16                    339     312     -8.0%     **1.09x (?)**
Set.isDisjoint.Seq.Empty.Box              89      82      -7.9%     **1.09x (?)**
LineSink.characters.complex               382     354     -7.3%     **1.08x (?)**
OpenClose                                 58      54      -6.9%     **1.07x (?)**

------- Code size: -O -------

REGRESSION                                OLD      NEW      DELTA    RATIO
DictionaryOfAnyHashableStrings.o          7920     10231    +29.2%   **0.77x**
ArrayAppend.o                             24553    27581    +12.3%   **0.89x**
ObserverForwarderStruct.o                 3036     3262     +7.4%    **0.93x**
ProtocolConformance.o                     3935     4127     +4.9%    **0.95x**
DictOfArraysToArrayOfDicts.o              22471    23527    +4.7%    **0.96x**
InsertCharacter.o                         4603     4795     +4.2%    **0.96x**
WordCount.o                               37081    38513    +3.9%    **0.96x**
COWTree.o                                 11474    11914    +3.8%    **0.96x**
NSDictionaryCastToSwift.o                 1514     1562     +3.2%    **0.97x**
DriverUtils.o                             129987   134023   +3.1%    **0.97x**
ObserverUnappliedMethod.o                 5193     5353     +3.1%    **0.97x**
DictionaryKeysContains.o                  8526     8739     +2.5%    **0.98x**
DictTest3.o                               15037    15405    +2.4%    **0.98x**
DictTest2.o                               10677    10933    +2.4%    **0.98x**
Phonebook.o                               9515     9723     +2.2%    **0.98x**
LinkedList.o                              2207     2255     +2.2%    **0.98x**
DictTest4.o                               14930    15218    +1.9%    **0.98x**
SubstringTest.o                           21172    21577    +1.9%    **0.98x**
RGBHistogram.o                            21322    21722    +1.9%    **0.98x**
DictTest.o                                13756    14012    +1.9%    **0.98x**
DictTest4Legacy.o                         15344    15616    +1.8%    **0.98x**
DiffingMyers.o                            6717     6829     +1.7%    **0.98x**
Combos.o                                  5822     5918     +1.6%    **0.98x**
CSVParsing.o                              53945    54793    +1.6%    **0.98x**
NibbleSort.o                              15054    15270    +1.4%    **0.99x**
RangeReplaceableCollectionPlusDefault.o   5724     5804     +1.4%    **0.99x**
QueueTest.o                               11989    12149    +1.3%    **0.99x**
Walsh.o                                   5180     5244     +1.2%    **0.99x**
IndexPathTest.o                           8520     8624     +1.2%    **0.99x**
MonteCarloE.o                             2825     2857     +1.1%    **0.99x**
ObjectiveCBridging.o                      58737    59369    +1.1%    **0.99x**
RangeAssignment.o                         3275     3310     +1.1%    **0.99x**
DictionarySwap.o                          16689    16865    +1.1%    **0.99x**

IMPROVEMENT                               OLD      NEW      DELTA    RATIO
FloatingPointParsing.o                    19809    16833    -15.0%   **1.18x**

------- Performance (x86_64): -Osize -------

REGRESSION                                OLD     NEW     DELTA     RATIO
StringFromLongWholeSubstringGeneric       3       16      +433.2%   **0.19x**
StringFromLongWholeSubstring              2       8       +299.9%   **0.25x**
SuffixArrayLazy                           5       9       +80.0%    **0.56x**
SuffixCountableRangeLazy                  5       9       +80.0%    **0.56x (?)**
DataCreateEmptyArray                      950     1450    +52.6%    **0.66x**
FrequenciesUsingReduce                    3290    4880    +48.3%    **0.67x (?)**
DropWhileAnySeqCRangeIterLazy             148     210     +41.9%    **0.70x**
DropWhileAnySeqCntRangeLazy               148     210     +41.9%    **0.70x (?)**
DictionaryLiteral                         2290    3070    +34.1%    **0.75x**
Dict.CopyKeyValue.28k                     1975    2645    +33.9%    **0.75x (?)**
MapReduceLazyCollection                   65      87      +33.8%    **0.75x**
DropWhileCountableRangeLazy               44      58      +31.8%    **0.76x (?)**
Dict.CopyKeyValue.16k                     1042    1373    +31.8%    **0.76x (?)**
DataCreateSmallArray                      1850    2400    +29.7%    **0.77x (?)**
Dict.CopyKeyValue.20k                     1165    1496    +28.4%    **0.78x (?)**
DictionaryRemoveOfObjects                 15200   19400   +27.6%    **0.78x (?)**
Dict.CopyKeyValue.24k                     1316    1649    +25.3%    **0.80x (?)**
DictionarySubscriptDefaultMutationArray   368     458     +24.5%    **0.80x (?)**
RemoveWhereFilterStrings                  298     368     +23.5%    **0.81x (?)**
RemoveWhereMoveStrings                    281     344     +22.4%    **0.82x (?)**
DropWhileArrayLazy                        44      53      +20.5%    **0.83x (?)**
Set.isSuperset.Seq.Box0                   198     236     +19.2%    **0.84x (?)**
TwoSum                                    996     1182    +18.7%    **0.84x**
Dictionary2OfObjects                      1540    1825    +18.5%    **0.84x (?)**
DropWhileSequenceLazy                     49      58      +18.4%    **0.84x (?)**
Dictionary2                               635     735     +15.7%    **0.86x (?)**
FrequenciesUsingReduceInto                670     770     +14.9%    **0.87x (?)**
DictionaryRemove                          3570    4090    +14.6%    **0.87x (?)**
SequenceAlgosRange                        1520    1740    +14.5%    **0.87x (?)**
Dictionary                                375     425     +13.3%    **0.88x (?)**
RemoveWhereFilterInts                     23      26      +13.0%    **0.88x**
SuffixAnyCollection                       39      44      +12.8%    **0.89x (?)**
DictionaryOfObjects                       1405    1585    +12.8%    **0.89x (?)**
Dictionary3OfObjects                      419     471     +12.4%    **0.89x (?)**
SequenceAlgosArray                        1710    1920    +12.3%    **0.89x (?)**
DropFirstAnyCollection                    112     125     +11.6%    **0.90x (?)**
ArraySetElement                           305     340     +11.5%    **0.90x**
AnyHashableWithAClass                     66500   74000   +11.3%    **0.90x (?)**
DictionarySwapOfObjects                   4720    5240    +11.0%    **0.90x (?)**
StrToInt                                  1000    1110    +11.0%    **0.90x (?)**
RGBHistogram                              2070    2290    +10.6%    **0.90x (?)**
ParseInt.UIntSmall.Binary                 512     562     +9.8%     **0.91x (?)**
Array2D                                   4272    4688    +9.7%     **0.91x (?)**
RGBHistogramOfObjects                     19600   21500   +9.7%     **0.91x (?)**
ProtocolConformance                       52      57      +9.6%     **0.91x (?)**
SetSymmetricDifferenceBox25               366     401     +9.6%     **0.91x (?)**
RemoveWhereSwapInts                       21      23      +9.5%     **0.91x (?)**
DictionaryGroupOfObjects                  1017    1107    +8.8%     **0.92x (?)**
MapReduceAnyCollection                    170     185     +8.8%     **0.92x (?)**
DataCreateMedium                          8000    8700    +8.7%     **0.92x (?)**
Data.append.Sequence.64kB.Count0          162     176     +8.6%     **0.92x (?)**
DictOfArraysToArrayOfDicts                498     540     +8.4%     **0.92x (?)**
SetExclusiveOr_OfObjects                  5020    5440    +8.4%     **0.92x (?)**
SetSymmetricDifferenceBox0                502     544     +8.4%     **0.92x (?)**
ObjectAllocation                          86      93      +8.1%     **0.92x (?)**
DataCreateMediumArray                     1520    1640    +7.9%     **0.93x (?)**
Data.init.Sequence.64kB.Count0.RE.I       166     179     +7.8%     **0.93x (?)**
Data.init.Sequence.64kB.Count0.RE         166     179     +7.8%     **0.93x (?)**

IMPROVEMENT                               OLD     NEW     DELTA     RATIO
ArrayAppendRepeatCol                      850     500     -41.2%    **1.70x (?)**
SumUsingReduce                            441     277     -37.2%    **1.59x**
Data.append.Sequence.64kB.Count.RE.I      44      29      -34.1%    **1.52x**
Data.append.Sequence.64kB.Count.RE        44      29      -34.1%    **1.52x**
Data.init.Sequence.64kB.Count.RE.I        43      29      -32.6%    **1.48x**
Data.init.Sequence.64kB.Count.RE          43      29      -32.6%    **1.48x (?)**
Data.init.Sequence.809B.Count.RE          72      54      -25.0%    **1.33x (?)**
Data.init.Sequence.809B.Count.RE.I        72      54      -25.0%    **1.33x (?)**
DropWhileAnySeqCRangeIter                 130     99      -23.8%    **1.31x (?)**
RecursiveOwnedParameter                   284     220     -22.5%    **1.29x (?)**
DropWhileAnySeqCntRange                   126     99      -21.4%    **1.27x (?)**
DataCountSmall                            19      15      -21.1%    **1.27x (?)**
Data.append.Sequence.809B.Count.RE.I      86      68      -20.9%    **1.26x (?)**
DataAppendSequence                        8700    6900    -20.7%    **1.26x (?)**
Data.append.Sequence.809B.Count.RE        85      68      -20.0%    **1.25x (?)**
ObjectiveCBridgeStubFromNSString          761     625     -17.9%    **1.22x (?)**
Breadcrumbs.MutatedIdxToUTF16.Mixed       222     192     -13.5%    **1.16x (?)**
Breadcrumbs.MutatedUTF16ToIdx.Mixed       217     189     -12.9%    **1.15x (?)**
DataCreateEmpty                           90      80      -11.1%    **1.12x (?)**
DataSubscriptSmall                        19      17      -10.5%    **1.12x (?)**
Set.isStrictSubset.Int0                   80      72      -10.0%    **1.11x (?)**
Set.subtracting.Empty.Box                 20      18      -10.0%    **1.11x (?)**
MapReduceString                           42      38      -9.5%     **1.11x (?)**
Set.isDisjoint.Seq.Empty.Int              87      79      -9.2%     **1.10x (?)**
Set.isDisjoint.Empty.Box                  88      80      -9.1%     **1.10x (?)**
Set.isDisjoint.Seq.Empty.Box              89      81      -9.0%     **1.10x (?)**
Set.isSuperset.Seq.Int.Empty              90      82      -8.9%     **1.10x (?)**
DropFirstAnySequence                      3700    3372    -8.9%     **1.10x (?)**
Set.isStrictSubset.Box0                   82      75      -8.5%     **1.09x (?)**
NormalizedIterator_fastPrenormal          470     430     -8.5%     **1.09x (?)**
NormalizedIterator_latin1                 168     156     -7.1%     **1.08x (?)**

------- Code size: -Osize -------

REGRESSION                                         OLD     NEW     DELTA    RATIO
DictionaryOfAnyHashableStrings.o                   5523    6165    +11.6%   **0.90x**
InsertCharacter.o                                  3983    4159    +4.4%    **0.96x**
ProtocolConformance.o                              3737    3894    +4.2%    **0.96x**
LuhnAlgoEager.o                                    14843   15347   +3.4%    **0.97x**
LuhnAlgoLazy.o                                     16067   16571   +3.1%    **0.97x**
NibbleSort.o                                       14234   14666   +3.0%    **0.97x**
DictOfArraysToArrayOfDicts.o                       19809   20377   +2.9%    **0.97x**
NSDictionaryCastToSwift.o                          1403    1441    +2.7%    **0.97x**
DictionaryKeysContains.o                           7814    8009    +2.5%    **0.98x**
Phonebook.o                                        8931    9135    +2.3%    **0.98x**
PrimsNonStrongRef.o                                86812   88526   +2.0%    **0.98x**
DictTest2.o                                        7916    8053    +1.7%    **0.98x**
Combos.o                                           5889    5987    +1.7%    **0.98x**
SubstringTest.o                                    19469   19778   +1.6%    **0.98x**
DictTest4.o                                        11274   11425   +1.3%    **0.99x**
BucketSort.o                                       8323    8433    +1.3%    **0.99x**
LinkedList.o                                       2055    2082    +1.3%    **0.99x**
DictTest4Legacy.o                                  11513   11664   +1.3%    **0.99x**
ObjectiveCBridging.o                               52891   53581   +1.3%    **0.99x**
ObserverForwarderStruct.o                          3142    3182    +1.3%    **0.99x**
DictTest.o                                         10896   11031   +1.2%    **0.99x**
WordCount.o                                        35114   35544   +1.2%    **0.99x**
RangeReplaceableCollectionPlusDefault.o            5579    5645    +1.2%    **0.99x**
RGBHistogram.o                                     19481   19709   +1.2%    **0.99x**
BinaryFloatingPointConversionFromBinaryInteger.o   28613   28941   +1.1%    **0.99x**
ArrayAppend.o                                      22429   22681   +1.1%    **0.99x**
DictionarySwap.o                                   14849   15006   +1.1%    **0.99x**
COWTree.o                                          11209   11325   +1.0%    **0.99x**
ArrayOfGenericRef.o                                8487    8573    +1.0%    **0.99x**

IMPROVEMENT                                        OLD     NEW     DELTA    RATIO
StaticArray.o                                      11790   10132   -14.1%   **1.16x**
CSVParsing.o                                       51414   50599   -1.6%    **1.02x**

------- Performance (x86_64): -Onone -------

REGRESSION                                         OLD       NEW       DELTA     RATIO
SIMDReduce.Int32                                   1514      3562      +135.3%   **0.43x**
SIMDReduce.Int8                                    6182      14472     +134.1%   **0.43x**
SIMDReduce.Int32x4.Cast                            634       1149      +81.2%    **0.55x**
SIMDReduce.Int8x16.Cast                            863       1449      +67.9%    **0.60x**
Dict.FilterAllMatch.28k                            3157      4659      +47.6%    **0.68x**
Dict.FilterAllMatch.16k                            1689      2489      +47.4%    **0.68x**
Dict.FilterAllMatch.20k                            1958      2879      +47.0%    **0.68x**
Dict.FilterAllMatch.24k                            2266      3310      +46.1%    **0.68x**
DataCreateMedium                                   183700    261300    +42.2%    **0.70x (?)**
FrequenciesUsingReduce                             5460      7720      +41.4%    **0.71x**
DataCreateSmall                                    25230     33180     +31.5%    **0.76x**
SetUnionInt100                                     219       286       +30.6%    **0.77x**
Dict.CopyKeyValue.16k                              2815      3628      +28.9%    **0.78x**
StringComparison_fastPrenormal                     1300      1670      +28.5%    **0.78x (?)**
Dict.CopyKeyValue.28k                              5144      6606      +28.4%    **0.78x (?)**
FrequenciesUsingReduceInto                         2570      3290      +28.0%    **0.78x**
Dict.CopyKeyValue.20k                              3364      4289      +27.5%    **0.78x**
StringComparison_slowerPrenormal                   970       1230      +26.8%    **0.79x**
Dict.CopyKeyValue.24k                              3953      5001      +26.5%    **0.79x (?)**
DictionarySubscriptDefaultMutationArray            3109      3931      +26.4%    **0.79x (?)**
DictionaryCompactMapValuesOfNilValue               10800     13650     +26.4%    **0.79x**
TwoSum                                             2286      2870      +25.5%    **0.80x**
DictionarySubscriptDefaultMutation                 3118      3894      +24.9%    **0.80x**
SIMDReduce.Int32x16.Cast                           777       966       +24.3%    **0.80x (?)**
StringComparison_longSharedPrefix                  569       696       +22.3%    **0.82x (?)**
StringComparison_emoji                             472       576       +22.0%    **0.82x**
StringComparison_latin1                            902       1098      +21.7%    **0.82x (?)**
StringComparison_nonBMPSlowestPrenormal            850       1030      +21.2%    **0.83x (?)**
StringRemoveDupes                                  487       584       +19.9%    **0.83x (?)**
Ackermann                                          5909      7057      +19.4%    **0.84x (?)**
Dictionary2                                        1085      1295      +19.4%    **0.84x (?)**
Dictionary                                         840       1000      +19.0%    **0.84x (?)**
SetUnionBox0                                       1789      2126      +18.8%    **0.84x (?)**
SetUnion_OfObjects                                 17900     21260     +18.8%    **0.84x (?)**
DictionaryLiteral                                  4930      5770      +17.0%    **0.85x (?)**
Dictionary2OfObjects                               2700      3160      +17.0%    **0.85x (?)**
ObserverForwarderStruct                            1795      2100      +17.0%    **0.85x (?)**
SetUnionInt50                                      309       361       +16.8%    **0.86x**
DictionaryCompactMapValuesOfCastValue              30240     35262     +16.6%    **0.86x (?)**
SIMDRandomMask.Int8x64                             16480     19211     +16.6%    **0.86x**
Data.init.Sequence.64kB.Count0.I                   1457      1679      +15.2%    **0.87x (?)**
RemoveWhereFilterStrings                           2322      2675      +15.2%    **0.87x (?)**
Data.init.Sequence.64kB.Count0                     1457      1676      +15.0%    **0.87x (?)**
StringFromLongWholeSubstringGeneric                40        46        +15.0%    **0.87x**
ObserverUnappliedMethod                            3960      4550      +14.9%    **0.87x (?)**
Data.append.Sequence.64kB.Count0.I                 1458      1675      +14.9%    **0.87x (?)**
Data.append.Sequence.64kB.Count0                   1457      1673      +14.8%    **0.87x (?)**
Data.init.Sequence.2049B.Count0.I                  2351      2698      +14.8%    **0.87x (?)**
Data.init.Sequence.2047B.Count0.I                  2352      2695      +14.6%    **0.87x (?)**
DictionarySubscriptDefaultMutationArrayOfObjects   6180      7080      +14.6%    **0.87x (?)**
Data.init.Sequence.809B.Count0.I                   1912      2187      +14.4%    **0.87x (?)**
SIMDRandomMask.Int8x16                             4213      4813      +14.2%    **0.88x (?)**
Data.init.Sequence.511B.Count0.I                   1863      2124      +14.0%    **0.88x (?)**
Data.append.Sequence.809B.Count0                   1873      2134      +13.9%    **0.88x (?)**
Data.append.Sequence.809B.Count0.I                 1873      2134      +13.9%    **0.88x (?)**
DictionaryRemoveOfObjects                          32300     36800     +13.9%    **0.88x (?)**
StringComparison_ascii                             1302      1482      +13.8%    **0.88x**
SetExclusiveOr_OfObjects                           26410     30030     +13.7%    **0.88x (?)**
CharIteration_korean_unicodeScalars                50800     57760     +13.7%    **0.88x (?)**
Data.init.Sequence.809B.Count0                     1926      2189      +13.7%    **0.88x (?)**
DictionarySubscriptDefaultMutationOfObjects        5860      6660      +13.7%    **0.88x**
SetSymmetricDifferenceBox0                         2643      3003      +13.6%    **0.88x (?)**
CStringLongNonAscii                                214       243       +13.6%    **0.88x (?)**
SetUnion                                           5630      6390      +13.5%    **0.88x (?)**
Dictionary3OfObjects                               1013      1149      +13.4%    **0.88x (?)**
Data.init.Sequence.513B.Count0.I                   1872      2122      +13.4%    **0.88x (?)**
SetUnionBox25                                      970       1099      +13.3%    **0.88x**
CharIteration_utf16_unicodeScalars                 61120     69160     +13.2%    **0.88x (?)**
SetUnionInt0                                       563       637       +13.1%    **0.88x (?)**
SetUnionInt25                                      346       390       +12.7%    **0.89x**
SetExclusiveOr                                     6810      7660      +12.5%    **0.89x (?)**
SetSymmetricDifferenceInt0                         682       767       +12.5%    **0.89x (?)**
Data.init.Sequence.2049B.Count.I                   2400      2697      +12.4%    **0.89x (?)**
Hanoi                                              7870      8840      +12.3%    **0.89x (?)**
Data.append.Sequence.64kB.Count.I                  1519      1706      +12.3%    **0.89x (?)**
Data.append.Sequence.809B.Count.I                  1959      2199      +12.3%    **0.89x (?)**
Data.init.Sequence.64kB.Count.I                    1521      1705      +12.1%    **0.89x (?)**
Data.append.Sequence.64kB.Count                    1525      1706      +11.9%    **0.89x (?)**
Data.init.Sequence.511B.Count.I                    1859      2079      +11.8%    **0.89x (?)**
Data.init.Sequence.809B.Count.I                    1929      2157      +11.8%    **0.89x (?)**
Dictionary3                                        398       445       +11.8%    **0.89x (?)**
Data.init.Sequence.64kB.Count                      1527      1706      +11.7%    **0.90x (?)**
Data.append.Sequence.809B.Count                    1963      2192      +11.7%    **0.90x (?)**
Data.init.Sequence.2047B.Count.I                   2412      2693      +11.7%    **0.90x (?)**
Data.init.Sequence.513B.Count.I                    1875      2091      +11.5%    **0.90x (?)**
Data.init.Sequence.809B.Count                      1947      2170      +11.5%    **0.90x (?)**
SIMDReduce.Int8x64.Cast                            1716      1912      +11.4%    **0.90x (?)**
DictionaryOfObjects                                2685      2970      +10.6%    **0.90x (?)**
SetSymmetricDifferenceBox25                        1323      1460      +10.4%    **0.91x (?)**
RandomDouble01LCG                                  21614     23837     +10.3%    **0.91x (?)**
RC4                                                11231     12378     +10.2%    **0.91x (?)**
PrefixCountableRange                               543       597       +9.9%     **0.91x (?)**
CStringLongAscii                                   213       234       +9.9%     **0.91x (?)**
AnyHashableWithAClass                              91500     100500    +9.8%     **0.91x (?)**
WordCountUniqueASCII                               7440      8170      +9.8%     **0.91x (?)**
ArrayAppendRepeatCol                               260310    285530    +9.7%     **0.91x (?)**
WordCountUniqueUTF16                               7640      8380      +9.7%     **0.91x (?)**
SuffixCountableRange                               187       205       +9.6%     **0.91x (?)**
Data.append.Sequence.64kB.Count0.RE.I              21280     23318     +9.6%     **0.91x (?)**
DictionarySwap                                     3592      3936      +9.6%     **0.91x (?)**
SetSymmetricDifferenceInt25                        441       482       +9.3%     **0.91x (?)**
Data.append.Sequence.809B.Count.RE                 26537     28995     +9.3%     **0.92x (?)**
Data.init.Sequence.809B.Count0.RE.I                26648     29097     +9.2%     **0.92x (?)**
Data.append.Sequence.64kB.Count.RE                 21620     23601     +9.2%     **0.92x (?)**
Data.append.Sequence.809B.Count0.RE.I              26483     28900     +9.1%     **0.92x (?)**
Data.init.Sequence.809B.Count.RE.I                 26708     29125     +9.0%     **0.92x (?)**
Data.append.Sequence.809B.Count.RE.I               26721     29128     +9.0%     **0.92x (?)**
QueueGeneric                                       13690     14920     +9.0%     **0.92x (?)**
Data.init.Sequence.64kB.Count0.RE                  21418     23340     +9.0%     **0.92x (?)**
Data.append.Sequence.809B.Count0.RE                26529     28909     +9.0%     **0.92x (?)**
DictionarySwapAt                                   2488      2708      +8.8%     **0.92x (?)**
Data.init.Sequence.64kB.Count0.RE.I                21487     23378     +8.8%     **0.92x (?)**
Data.init.Sequence.809B.Count.RE                   26875     29225     +8.7%     **0.92x (?)**
Data.init.Sequence.64kB.Count.RE.I                 21669     23537     +8.6%     **0.92x (?)**
StringHashing_latin1                               140       152       +8.6%     **0.92x (?)**
Data.init.Sequence.809B.Count0.RE                  26744     29031     +8.6%     **0.92x (?)**
Data.append.Sequence.64kB.Count0.RE                21464     23287     +8.5%     **0.92x (?)**
Data.init.Sequence.64kB.Count.RE                   21654     23481     +8.4%     **0.92x (?)**
StringHashing_slowerPrenormal                      240       260       +8.3%     **0.92x (?)**
Dictionary4OfObjects                               950       1029      +8.3%     **0.92x (?)**
DropFirstCountableRange                            543       588       +8.3%     **0.92x (?)**
Dictionary4OfObjectsLegacy                         1050      1136      +8.2%     **0.92x (?)**
Data.append.Sequence.64kB.Count.RE.I               21616     23378     +8.2%     **0.92x (?)**
SIMDRandomMask.Int64x8                             2766      2991      +8.1%     **0.92x (?)**
DataAppendSequence                                 2686400   2903900   +8.1%     **0.93x (?)**
Dictionary4                                        606       655       +8.1%     **0.93x (?)**
QueueConcrete                                      8680      9380      +8.1%     **0.93x (?)**
DropLastCountableRange                             187       202       +8.0%     **0.93x (?)**
SetSymmetricDifferenceInt50                        424       458       +8.0%     **0.93x (?)**
Chars2                                             6250      6750      +8.0%     **0.93x (?)**
Set.isSuperset.Seq.Empty.Int                       589       636       +8.0%     **0.93x (?)**
Histogram                                          4846      5222      +7.8%     **0.93x (?)**
StringUTF16Builder                                 1830      1970      +7.7%     **0.93x (?)**
ByteSwap                                           4082      4393      +7.6%     **0.93x (?)**
SIMDRandomMask.Int64x64                            30302     32589     +7.5%     **0.93x (?)**

IMPROVEMENT                                        OLD       NEW       DELTA     RATIO
Breadcrumbs.MutatedUTF16ToIdx.Mixed                221       191       -13.6%    **1.16x (?)**
Breadcrumbs.MutatedIdxToUTF16.Mixed                232       202       -12.9%    **1.15x (?)**

@nate-chandler
Copy link
Contributor Author 

------- Performance (x86_64): -O -------

REGRESSION                                OLD     NEW     DELTA     RATIO
StringFromLongWholeSubstringGeneric       3       16      +433.2%   **0.19x**
StringFromLongWholeSubstring              2       7       +249.9%   **0.29x**
DataCreateEmptyArray                      850     1400    +64.7%    **0.61x**
Set.isSuperset.Seq.Box0                   129     207     +60.5%    **0.62x**
DropWhileArrayLazy                        31      49      +58.1%    **0.63x**
FlattenListLoop                           1026    1590    +55.0%    **0.65x (?)**
ObserverForwarderStruct                   680     1030    +51.5%    **0.66x**
DictionarySubscriptDefaultMutationArray   277     402     +45.1%    **0.69x**
DataCountSmall                            15      19      +26.7%    **0.79x (?)**
DataCreateEmpty                           80      100     +25.0%    **0.80x**
SortIntPyramid                            360     445     +23.6%    **0.81x (?)**
RemoveWhereFilterStrings                  298     366     +22.8%    **0.81x (?)**
RemoveWhereMoveStrings                    280     339     +21.1%    **0.83x (?)**
DataCreateSmallArray                      1700    2050    +20.6%    **0.83x (?)**
ParseInt.UIntSmall.Binary                 438     519     +18.5%    **0.84x (?)**
FlattenListFlatMap                        2440    2884    +18.2%    **0.85x (?)**
ReversedArray2                            96      109     +13.5%    **0.88x (?)**
DataCountMedium                           15      17      +13.3%    **0.88x (?)**
AnyHashableWithAClass                     66500   74500   +12.0%    **0.89x (?)**
ArrayPlusEqualSingleElementCollection     423     470     +11.1%    **0.90x (?)**
Set.isStrictSubset.Int0                   72      80      +11.1%    **0.90x (?)**
Dictionary3OfObjects                      345     383     +11.0%    **0.90x (?)**
DictionaryOfAnyHashableStrings_insert     3402    3766    +10.7%    **0.90x (?)**
SetSymmetricDifferenceBox25               297     327     +10.1%    **0.91x (?)**
ProtocolConformance                       52      57      +9.6%     **0.91x (?)**
ParseInt.IntSmall.UncommonRadix           322     352     +9.3%     **0.91x (?)**
SetExclusiveOr_OfObjects                  4280    4670    +9.1%     **0.92x (?)**
SetSymmetricDifferenceBox0                428     467     +9.1%     **0.92x (?)**
DropFirstSequenceLazy                     22      24      +9.1%     **0.92x (?)**
DictionarySwapOfObjects                   4640    5000    +7.8%     **0.93x (?)**

IMPROVEMENT                               OLD     NEW     DELTA     RATIO
Data.append.Sequence.64kB.Count.RE.I      29      21      -27.6%    **1.38x (?)**
Data.append.Sequence.64kB.Count.RE        29      21      -27.6%    **1.38x (?)**
BinaryFloatingPointPropertiesUlp          26      19      -26.9%    **1.37x**
ArrayAppendLazyMap                        1720    1440    -16.3%    **1.19x (?)**
DataAppendSequence                        6800    5700    -16.2%    **1.19x (?)**
Data.append.Sequence.809B.Count.RE        68      57      -16.2%    **1.19x (?)**
Data.append.Sequence.809B.Count.RE.I      68      57      -16.2%    **1.19x (?)**
Set.subtracting.Empty.Box                 20      17      -15.0%    **1.18x (?)**
DataSubscriptSmall                        15      13      -13.3%    **1.15x (?)**
StringBuilder                             203     180     -11.3%    **1.13x (?)**
StringAdder                               270     240     -11.1%    **1.12x (?)**
StringBuilderSmallReservingCapacity       208     187     -10.1%    **1.11x (?)**
StringUTF16Builder                        210     190     -9.5%     **1.11x (?)**
SIMDRandomMask.Int8x16                    339     312     -8.0%     **1.09x (?)**
StringToDataSmall                         700     650     -7.1%     **1.08x (?)**

------- Code size: -O -------

REGRESSION                                OLD      NEW      DELTA    RATIO
DictionaryOfAnyHashableStrings.o          7904     10231    +29.4%   **0.77x**
ArrayAppend.o                             24769    27409    +10.7%   **0.90x**
ObserverForwarderStruct.o                 3156     3382     +7.2%    **0.93x**
ProtocolConformance.o                     4055     4247     +4.7%    **0.95x**
DictOfArraysToArrayOfDicts.o              22591    23647    +4.7%    **0.96x**
InsertCharacter.o                         4603     4795     +4.2%    **0.96x**
WordCount.o                               37153    38521    +3.7%    **0.96x**
ObserverUnappliedMethod.o                 5313     5489     +3.3%    **0.97x**
NSDictionaryCastToSwift.o                 1514     1562     +3.2%    **0.97x**
COWTree.o                                 11562    11898    +2.9%    **0.97x**
DriverUtils.o                             130187   133771   +2.8%    **0.97x**
DictionaryKeysContains.o                  8526     8739     +2.5%    **0.98x**
DictTest3.o                               15037    15405    +2.4%    **0.98x**
DictTest2.o                               10677    10933    +2.4%    **0.98x**
LinkedList.o                              2207     2255     +2.2%    **0.98x**
DictTest4.o                               14930    15218    +1.9%    **0.98x**
SubstringTest.o                           21172    21577    +1.9%    **0.98x**
DictTest.o                                13756    14012    +1.9%    **0.98x**
DictTest4Legacy.o                         15344    15616    +1.8%    **0.98x**
DiffingMyers.o                            6741     6853     +1.7%    **0.98x**
Combos.o                                  5822     5918     +1.6%    **0.98x**
RGBHistogram.o                            21394    21730    +1.6%    **0.98x**
CSVParsing.o                              54225    55073    +1.6%    **0.98x**
Phonebook.o                               9571     9715     +1.5%    **0.99x**
RangeReplaceableCollectionPlusDefault.o   5692     5772     +1.4%    **0.99x**
QueueTest.o                               11973    12133    +1.3%    **0.99x**
Walsh.o                                   5180     5244     +1.2%    **0.99x**
IndexPathTest.o                           8520     8624     +1.2%    **0.99x**
MonteCarloE.o                             2825     2857     +1.1%    **0.99x**
ObjectiveCBridging.o                      58817    59449    +1.1%    **0.99x**
RangeAssignment.o                         3275     3310     +1.1%    **0.99x**
DictionarySwap.o                          16689    16865    +1.1%    **0.99x**

IMPROVEMENT                               OLD      NEW      DELTA    RATIO
FloatingPointParsing.o                    19809    16833    -15.0%   **1.18x**

------- Performance (x86_64): -Osize -------

REGRESSION                                               OLD     NEW     DELTA     RATIO
StringFromLongWholeSubstringGeneric                      3       16      +433.2%   **0.19x**
StringFromLongWholeSubstring                             2       8       +299.9%   **0.25x**
ArrayAppendRepeatCol                                     500     850     +70.0%    **0.59x (?)**
DataCreateEmptyArray                                     850     1400    +64.7%    **0.61x**
FrequenciesUsingReduce                                   3280    4960    +51.2%    **0.66x**
DropWhileAnySeqCRangeIterLazy                            148     210     +41.9%    **0.70x (?)**
DropWhileAnySeqCntRangeLazy                              148     210     +41.9%    **0.70x**
UTF8Decode_InitFromCustom_noncontiguous_ascii_as_ascii   684     927     +35.5%    **0.74x**
DictionaryLiteral                                        2290    3090    +34.9%    **0.74x (?)**
MapReduceLazyCollection                                  65      87      +33.8%    **0.75x**
DataCreateSmallArray                                     1800    2400    +33.3%    **0.75x (?)**
DropWhileCountableRangeLazy                              44      58      +31.8%    **0.76x**
Dict.CopyKeyValue.28k                                    2000    2635    +31.7%    **0.76x**
Dict.CopyKeyValue.16k                                    1055    1372    +30.0%    **0.77x (?)**
UTF8Decode_InitFromCustom_noncontiguous_ascii            623     810     +30.0%    **0.77x (?)**
ArrayAppendUTF16Substring                                18936   24264   +28.1%    **0.78x (?)**
ArrayAppendLatin1Substring                               19368   24804   +28.1%    **0.78x**
ArrayAppendAsciiSubstring                                18936   24228   +27.9%    **0.78x (?)**
DictionaryRemoveOfObjects                                15200   19400   +27.6%    **0.78x**
Dict.CopyKeyValue.20k                                    1176    1494    +27.0%    **0.79x (?)**
Set.isSuperset.Seq.Box0                                  192     242     +26.0%    **0.79x (?)**
Dict.CopyKeyValue.24k                                    1327    1643    +23.8%    **0.81x (?)**
DictionarySubscriptDefaultMutationArray                  372     460     +23.7%    **0.81x (?)**
RemoveWhereFilterStrings                                 298     367     +23.2%    **0.81x**
UTF8Decode_InitFromCustom_noncontiguous                  262     322     +22.9%    **0.81x (?)**
RemoveWhereMoveStrings                                   280     344     +22.9%    **0.81x (?)**
DropWhileArrayLazy                                       44      53      +20.5%    **0.83x (?)**
TwoSum                                                   998     1192    +19.4%    **0.84x (?)**
Dictionary2OfObjects                                     1535    1830    +19.2%    **0.84x (?)**
DropWhileSequenceLazy                                    49      58      +18.4%    **0.84x (?)**
DictionaryRemove                                         3580    4170    +16.5%    **0.86x (?)**
FrequenciesUsingReduceInto                               660     760     +15.2%    **0.87x (?)**
RemoveWhereSwapInts                                      20      23      +15.0%    **0.87x (?)**
Dictionary2                                              635     730     +15.0%    **0.87x (?)**
SequenceAlgosRange                                       1520    1740    +14.5%    **0.87x (?)**
Dictionary                                               370     420     +13.5%    **0.88x (?)**
ObjectAllocation                                         85      96      +12.9%    **0.89x (?)**
SequenceAlgosArray                                       1710    1920    +12.3%    **0.89x (?)**
Dictionary3OfObjects                                     420     471     +12.1%    **0.89x (?)**
DictionaryOfObjects                                      1410    1580    +12.1%    **0.89x (?)**
AnyHashableWithAClass                                    66500   74500   +12.0%    **0.89x (?)**
DropFirstAnyCollection                                   111     124     +11.7%    **0.90x (?)**
ParseInt.UIntSmall.Binary                                506     563     +11.3%    **0.90x (?)**
RGBHistogram                                             2050    2280    +11.2%    **0.90x (?)**
DictionaryOfAnyHashableStrings_insert                    3850    4270    +10.9%    **0.90x (?)**
DropLastAnySequenceLazy                                  3143    3470    +10.4%    **0.91x (?)**
MapReduceAnyCollection                                   169     185     +9.5%     **0.91x (?)**
Calculator                                               138     151     +9.4%     **0.91x (?)**
RGBHistogramOfObjects                                    19600   21400   +9.2%     **0.92x (?)**
SetSymmetricDifferenceBox25                              368     401     +9.0%     **0.92x (?)**
OpenClose                                                56      61      +8.9%     **0.92x (?)**
PrefixAnyCollection                                      114     124     +8.8%     **0.92x (?)**
SubstringFromLongStringGeneric                           12      13      +8.3%     **0.92x (?)**
DictionarySwapOfObjects                                  4840    5240    +8.3%     **0.92x (?)**
SetExclusiveOr_OfObjects                                 5020    5430    +8.2%     **0.92x (?)**
DictionaryGroupOfObjects                                 1017    1098    +8.0%     **0.93x (?)**
Prims                                                    755     815     +7.9%     **0.93x (?)**
PrimsSplit                                               760     820     +7.9%     **0.93x (?)**
DropWhileArray                                           26      28      +7.7%     **0.93x (?)**
ProtocolConformance                                      53      57      +7.5%     **0.93x (?)**

IMPROVEMENT                                              OLD     NEW     DELTA     RATIO
SumUsingReduce                                           441     278     -37.0%    **1.59x**
FlattenListLoop                                          1587    1030    -35.1%    **1.54x (?)**
DropWhileAnySeqCRangeIter                                130     99      -23.8%    **1.31x (?)**
DropWhileAnySeqCntRange                                  126     99      -21.4%    **1.27x (?)**
ConvertFloatingPoint.MockFloat64Exactly                  5       4       -20.0%    **1.25x (?)**
DataSubscriptMedium                                      45      39      -13.3%    **1.15x (?)**
StringBuilder                                            203     178     -12.3%    **1.14x (?)**
StringBuilderSmallReservingCapacity                      210     186     -11.4%    **1.13x (?)**
CreateObjects                                            9       8       -11.1%    **1.12x (?)**
DataCountSmall                                           19      17      -10.5%    **1.12x (?)**
StringAdder                                              268     240     -10.4%    **1.12x (?)**
Set.subtracting.Empty.Box                                20      18      -10.0%    **1.11x (?)**
StringUTF16Builder                                       210     190     -9.5%     **1.11x (?)**
MapReduceString                                          42      38      -9.5%     **1.11x (?)**

------- Code size: -Osize -------

REGRESSION                                         OLD     NEW     DELTA    RATIO
DictionaryOfAnyHashableStrings.o                   5591    6233    +11.5%   **0.90x**
InsertCharacter.o                                  3983    4159    +4.4%    **0.96x**
ProtocolConformance.o                              3809    3966    +4.1%    **0.96x**
LuhnAlgoEager.o                                    14843   15347   +3.4%    **0.97x**
LuhnAlgoLazy.o                                     16067   16571   +3.1%    **0.97x**
DictOfArraysToArrayOfDicts.o                       19881   20449   +2.9%    **0.97x**
NSDictionaryCastToSwift.o                          1403    1441    +2.7%    **0.97x**
NibbleSort.o                                       14311   14686   +2.6%    **0.97x**
DictionaryKeysContains.o                           7814    8009    +2.5%    **0.98x**
PrimsNonStrongRef.o                                87784   89570   +2.0%    **0.98x**
DictTest2.o                                        7916    8053    +1.7%    **0.98x**
Combos.o                                           5957    6055    +1.6%    **0.98x**
Phonebook.o                                        9049    9196    +1.6%    **0.98x**
SubstringTest.o                                    19537   19846   +1.6%    **0.98x**
DictTest4.o                                        11274   11425   +1.3%    **0.99x**
LinkedList.o                                       2055    2082    +1.3%    **0.99x**
COWTree.o                                          11278   11426   +1.3%    **0.99x**
DictTest4Legacy.o                                  11513   11664   +1.3%    **0.99x**
ObjectiveCBridging.o                               52907   53597   +1.3%    **0.99x**
BucketSort.o                                       8463    8573    +1.3%    **0.99x**
ObserverForwarderStruct.o                          3214    3254    +1.2%    **0.99x**
DictTest.o                                         10896   11031   +1.2%    **0.99x**
RangeReplaceableCollectionPlusDefault.o            5620    5686    +1.2%    **0.99x**
BinaryFloatingPointConversionFromBinaryInteger.o   28613   28941   +1.1%    **0.99x**
ArrayAppend.o                                      22885   23137   +1.1%    **0.99x**
WordCount.o                                        35191   35564   +1.1%    **0.99x**
DictionarySwap.o                                   14849   15006   +1.1%    **0.99x**

IMPROVEMENT                                        OLD     NEW     DELTA    RATIO
StaticArray.o                                      11867   10152   -14.5%   **1.17x**
CSVParsing.o                                       51766   50951   -1.6%    **1.02x**

------- Performance (x86_64): -Onone -------

REGRESSION                                         OLD      NEW      DELTA     RATIO
SIMDReduce.Int32                                   1541     3571     +131.7%   **0.43x**
SIMDReduce.Int8                                    6317     14388    +127.8%   **0.44x**
SIMDReduce.Int32x4.Cast                            647      1154     +78.4%    **0.56x**
SIMDReduce.Int8x16.Cast                            876      1443     +64.7%    **0.61x**
Dict.FilterAllMatch.20k                            1947     2840     +45.9%    **0.69x**
Dict.FilterAllMatch.28k                            3151     4594     +45.8%    **0.69x**
Dict.FilterAllMatch.16k                            1687     2453     +45.4%    **0.69x**
Dict.FilterAllMatch.24k                            2257     3256     +44.3%    **0.69x**
FrequenciesUsingReduce                             5490     7810     +42.3%    **0.70x (?)**
DataCreateMedium                                   185600   259400   +39.8%    **0.72x (?)**
DataCreateSmall                                    25420    33180    +30.5%    **0.77x**
Dict.CopyKeyValue.28k                              5129     6605     +28.8%    **0.78x (?)**
Dict.CopyKeyValue.16k                              2809     3611     +28.6%    **0.78x (?)**
StringComparison_fastPrenormal                     1300     1670     +28.5%    **0.78x**
FrequenciesUsingReduceInto                         2570     3300     +28.4%    **0.78x (?)**
Dict.CopyKeyValue.20k                              3352     4282     +27.7%    **0.78x (?)**
SetUnionInt100                                     225      286      +27.1%    **0.79x**
Dict.CopyKeyValue.24k                              3938     4986     +26.6%    **0.79x (?)**
TwoSum                                             2282     2858     +25.2%    **0.80x (?)**
DictionaryCompactMapValuesOfNilValue               10950    13650    +24.7%    **0.80x**
StringComparison_longSharedPrefix                  532      662      +24.4%    **0.80x (?)**
StringComparison_slowerPrenormal                   990      1230     +24.2%    **0.80x**
DictionarySubscriptDefaultMutationArray            3195     3963     +24.0%    **0.81x (?)**
DictionarySubscriptDefaultMutation                 3001     3718     +23.9%    **0.81x (?)**
StringComparison_latin1                            882      1082     +22.7%    **0.82x**
StringComparison_nonBMPSlowestPrenormal            840      1020     +21.4%    **0.82x (?)**
SIMDReduce.Int32x16.Cast                           786      954      +21.4%    **0.82x**
StringComparison_emoji                             468      568      +21.4%    **0.82x (?)**
Ackermann                                          5914     7055     +19.3%    **0.84x**
SetUnion_OfObjects                                 18010    21340    +18.5%    **0.84x**
SetUnionBox0                                       1801     2134     +18.5%    **0.84x (?)**
Dictionary                                         845      995      +17.8%    **0.85x (?)**
Dictionary2                                        1100     1295     +17.7%    **0.85x (?)**
ObserverForwarderStruct                            1790     2100     +17.3%    **0.85x (?)**
Dictionary2OfObjects                               2700     3165     +17.2%    **0.85x (?)**
SIMDRandomMask.Int8x64                             16812    19575    +16.4%    **0.86x**
DictionaryLiteral                                  4990     5790     +16.0%    **0.86x (?)**
StringRemoveDupes                                  501      581      +16.0%    **0.86x (?)**
DictionaryCompactMapValuesOfCastValue              30564    35262    +15.4%    **0.87x**
SIMDRandomMask.Int8x16                             4168     4797     +15.1%    **0.87x (?)**
StringFromLongWholeSubstringGeneric                40       46       +15.0%    **0.87x (?)**
ObserverUnappliedMethod                            3970     4560     +14.9%    **0.87x (?)**
DictionarySubscriptDefaultMutationArrayOfObjects   6160     7060     +14.6%    **0.87x (?)**
SetUnionInt50                                      313      358      +14.4%    **0.87x (?)**
Data.init.Sequence.2047B.Count0.I                  2341     2677     +14.4%    **0.87x (?)**
RC4                                                11246    12843    +14.2%    **0.88x (?)**
Data.init.Sequence.2049B.Count0.I                  2345     2678     +14.2%    **0.88x (?)**
RemoveWhereFilterStrings                           2339     2671     +14.2%    **0.88x**
DictionarySubscriptDefaultMutationOfObjects        5880     6700     +13.9%    **0.88x (?)**
Data.init.Sequence.809B.Count0.I                   1909     2175     +13.9%    **0.88x (?)**
Data.init.Sequence.64kB.Count0.I                   1456     1658     +13.9%    **0.88x (?)**
Data.init.Sequence.809B.Count0                     1922     2187     +13.8%    **0.88x (?)**
SetSymmetricDifferenceBox0                         2658     3022     +13.7%    **0.88x (?)**
SetExclusiveOr_OfObjects                           26570    30200    +13.7%    **0.88x**
Data.init.Sequence.64kB.Count0                     1457     1656     +13.7%    **0.88x (?)**
Data.init.Sequence.513B.Count0.I                   1868     2121     +13.5%    **0.88x (?)**
Data.init.Sequence.511B.Count0.I                   1863     2114     +13.5%    **0.88x (?)**
Data.append.Sequence.64kB.Count0.I                 1461     1654     +13.2%    **0.88x (?)**
NormalizedIterator_fastPrenormal                   460      520      +13.0%    **0.88x (?)**
SetUnionBox25                                      977      1104     +13.0%    **0.88x (?)**
Data.append.Sequence.809B.Count0.I                 1873     2114     +12.9%    **0.89x (?)**
Data.append.Sequence.64kB.Count0                   1463     1651     +12.9%    **0.89x (?)**
Data.append.Sequence.809B.Count0                   1873     2113     +12.8%    **0.89x (?)**
CStringShortAscii                                  2600     2930     +12.7%    **0.89x (?)**
Dictionary3OfObjects                               1021     1149     +12.5%    **0.89x (?)**
DictionaryOfAnyHashableStrings_insert              4186     4690     +12.0%    **0.89x (?)**
DictionaryRemoveOfObjects                          32700    36600    +11.9%    **0.89x (?)**
StringComparison_ascii                             1338     1494     +11.7%    **0.90x (?)**
StringHashing_latin1                               138      154      +11.6%    **0.90x**
Hanoi                                              8020     8940     +11.5%    **0.90x (?)**
SIMDReduce.Int8x64.Cast                            1724     1917     +11.2%    **0.90x (?)**
WordCountUniqueUTF16                               7700     8560     +11.2%    **0.90x (?)**
WordCountUniqueASCII                               7530     8370     +11.2%    **0.90x (?)**
SetUnionInt0                                       568      629      +10.7%    **0.90x (?)**
SetUnion                                           5690     6300     +10.7%    **0.90x (?)**
Data.init.Sequence.64kB.Count                      1526     1689     +10.7%    **0.90x (?)**
DictionaryOfObjects                                2680     2965     +10.6%    **0.90x (?)**
SIMDRandomMask.Int64x8                             2708     2991     +10.5%    **0.91x (?)**
StringToDataEmpty                                  2400     2650     +10.4%    **0.91x (?)**
Dictionary3                                        404      446      +10.4%    **0.91x (?)**
RandomDouble01LCG                                  21876    24144    +10.4%    **0.91x (?)**
NormalizedIterator_slowerPrenormal                 290      320      +10.3%    **0.91x (?)**
SetSymmetricDifferenceBox25                        1334     1471     +10.3%    **0.91x**
StringToDataSmall                                  2450     2700     +10.2%    **0.91x (?)**
Data.append.Sequence.64kB.Count.I                  1530     1686     +10.2%    **0.91x (?)**
Data.init.Sequence.64kB.Count.I                    1535     1689     +10.0%    **0.91x (?)**
SetUnionInt25                                      350      385      +10.0%    **0.91x (?)**
ArrayOfPOD                                         669      735      +9.9%     **0.91x (?)**
SetSymmetricDifferenceInt0                         692      760      +9.8%     **0.91x (?)**
QueueConcrete                                      8570     9400     +9.7%     **0.91x (?)**
SetExclusiveOr                                     6920     7590     +9.7%     **0.91x (?)**
CStringLongNonAscii                                217      238      +9.7%     **0.91x (?)**
ArrayAppendUTF16                                   10234    11220    +9.6%     **0.91x (?)**
Data.append.Sequence.809B.Count.I                  1976     2163     +9.5%     **0.91x (?)**
PrefixCountableRange                               544      595      +9.4%     **0.91x (?)**
CharIteration_utf16_unicodeScalars                 61320    66920    +9.1%     **0.92x (?)**
SuffixCountableRange                               187      204      +9.1%     **0.92x (?)**
CharIteration_russian_unicodeScalars               45040    49080    +9.0%     **0.92x (?)**
Data.append.Sequence.809B.Count                    1978     2155     +8.9%     **0.92x (?)**
SIMDRandomMask.Int64x64                            30217    32907    +8.9%     **0.92x**
Data.init.Sequence.809B.Count                      1961     2134     +8.8%     **0.92x (?)**
Data.init.Sequence.809B.Count.I                    1941     2110     +8.7%     **0.92x (?)**
AnyHashableWithAClass                              92000    100000   +8.7%     **0.92x (?)**
CharIteration_korean_unicodeScalars                52200    56680    +8.6%     **0.92x (?)**
Set.isSuperset.Seq.Empty.Int                       597      648      +8.5%     **0.92x**
NormalizedIterator_latin1                          188      204      +8.5%     **0.92x (?)**
Data.init.Sequence.513B.Count.I                    1888     2047     +8.4%     **0.92x (?)**
CharIteration_tweet_unicodeScalars                 103440   112080   +8.4%     **0.92x (?)**
Set.isSuperset.Seq.Box0                            1635     1771     +8.3%     **0.92x (?)**
QueueGeneric                                       13780    14920    +8.3%     **0.92x (?)**
SubstringEqualString                               746      807      +8.2%     **0.92x (?)**
DictOfArraysToArrayOfDicts                         2402     2598     +8.2%     **0.92x (?)**
SIMDRandomMask.Int64x2                             970      1046     +7.8%     **0.93x (?)**
DropFirstCountableRange                            544      586      +7.7%     **0.93x (?)**
DropLastAnySequenceLazy                            9580     10319    +7.7%     **0.93x (?)**

------- Code size: -swiftlibs -------

REGRESSION                        OLD      NEW      DELTA   RATIO
libswift_Differentiation.dylib    229376   245760   +7.1%   **0.93x**
libswiftStdlibUnittest.dylib      311296   327680   +5.3%   **0.95x**
libswift_MatchingEngine.dylib     671744   688128   +2.4%   **0.98x**
libswift_StringProcessing.dylib   688128   704512   +2.4%   **0.98x**

@nate-chandler nate-chandler force-pushed the lexical_lifetimes/destroy-hoisting/disable branch from e48a4ac to 777dcb5 Compare February 22, 2022 23:24
@nate-chandler
Copy link
Contributor Author 

------- Performance (x86_64): -O -------

REGRESSION                                OLD    NEW    DELTA     RATIO
StringFromLongWholeSubstring              2      8      +299.9%   **0.25x**
StringFromLongWholeSubstringGeneric       3      9      +199.9%   **0.33x**
DataCreateEmptyArray                      850    1400   +64.7%    **0.61x (?)**
Set.isSuperset.Seq.Box0                   129    207    +60.5%    **0.62x (?)**
LessSubstringSubstring                    22     30     +36.4%    **0.73x (?)**
EqualSubstringSubstringGenericEquatable   22     30     +36.4%    **0.73x (?)**
LessSubstringSubstringGenericComparable   22     30     +36.4%    **0.73x (?)**
EqualSubstringSubstring                   22     29     +31.8%    **0.76x (?)**
EqualStringSubstring                      22     29     +31.8%    **0.76x (?)**
EqualSubstringString                      22     29     +31.8%    **0.76x (?)**
DataCountSmall                            15     19     +26.7%    **0.79x**
DataCreateSmallArray                      1700   2100   +23.5%    **0.81x (?)**
RemoveWhereMoveStrings                    280    341    +21.8%    **0.82x (?)**
ObjectiveCBridgeStringHash                85     97     +14.1%    **0.88x (?)**
DataCountMedium                           15     17     +13.3%    **0.88x (?)**
StringComparison_longSharedPrefix         296    333    +12.5%    **0.89x (?)**
SortStringsUnicode                        2020   2220   +9.9%     **0.91x (?)**
SubstringEqualString                      155    170    +9.7%     **0.91x (?)**
BridgeString.find.native.longNonASCII     398    436    +9.5%     **0.91x (?)**
ObjectiveCBridgeStringGetASCIIContents    317    346    +9.1%     **0.92x (?)**
ArrayAppendLatin1                         1802   1938   +7.5%     **0.93x (?)**

IMPROVEMENT                               OLD    NEW    DELTA     RATIO
Set.subtracting.Box.Empty                 38     24     -36.8%    **1.58x**
Set.subtracting.Int.Empty                 43     28     -34.9%    **1.54x**
Data.append.Sequence.64kB.Count.RE        29     21     -27.6%    **1.38x**
BinaryFloatingPointPropertiesUlp          26     19     -26.9%    **1.37x**
Data.append.Sequence.64kB.Count.RE.I      29     22     -24.1%    **1.32x (?)**
ArrayAppendRepeatCol                      500    400    -20.0%    **1.25x (?)**
Data.append.Sequence.809B.Count.RE.I      70     57     -18.6%    **1.23x (?)**
DataAppendSequence                        6900   5700   -17.4%    **1.21x (?)**
Data.append.Sequence.809B.Count.RE        69     58     -15.9%    **1.19x (?)**
DataSubscriptSmall                        15     13     -13.3%    **1.15x (?)**
StringAdder                               270    239    -11.5%    **1.13x (?)**
StringBuilderSmallReservingCapacity       210    187    -11.0%    **1.12x (?)**
StringBuilder                             201    180    -10.4%    **1.12x (?)**
StringUTF16Builder                        210    190    -9.5%     **1.11x (?)**
ArrayAppendLazyMap                        1720   1560   -9.3%     **1.10x (?)**
RemoveWhereFilterString                   209    194    -7.2%     **1.08x (?)**
LineSink.characters.complex               379    353    -6.9%     **1.07x (?)**
String.replaceSubrange.ArrChar.Small      45     42     -6.7%     **1.07x (?)**

------- Code size: -O -------

REGRESSION                                         OLD     NEW     DELTA   RATIO
DictOfArraysToArrayOfDicts.o                       22591   23407   +3.6%   **0.97x**
NSDictionaryCastToSwift.o                          1514    1562    +3.2%   **0.97x**
BinaryFloatingPointConversionFromBinaryInteger.o   29608   30376   +2.6%   **0.97x**
SubstringTest.o                                    21108   21529   +2.0%   **0.98x**
InsertCharacter.o                                  4603    4683    +1.7%   **0.98x**
DictTest4.o                                        14930   15122   +1.3%   **0.99x**
Walsh.o                                            5180    5244    +1.2%   **0.99x**
IndexPathTest.o                                    8520    8624    +1.2%   **0.99x**
ProtocolConformance.o                              4055    4103    +1.2%   **0.99x**
DictTest4Legacy.o                                  15344   15520   +1.1%   **0.99x**
MonteCarloE.o                                      2825    2857    +1.1%   **0.99x**
Combos.o                                           5822    5886    +1.1%   **0.99x**
ArrayAppend.o                                      24769   25041   +1.1%   **0.99x**
RGBHistogram.o                                     21394   21618   +1.0%   **0.99x**

IMPROVEMENT                                        OLD     NEW     DELTA   RATIO
ErrorHandling.o                                    3425    3265    -4.7%   **1.05x**
DictionaryKeysContains.o                           8526    8296    -2.7%   **1.03x**

------- Performance (x86_64): -Osize -------

REGRESSION                                               OLD     NEW     DELTA     RATIO
StringFromLongWholeSubstring                             2       8       +299.9%   **0.25x**
StringFromLongWholeSubstringGeneric                      3       9       +199.9%   **0.33x**
DataCreateEmptyArray                                     850     1450    +70.6%    **0.59x**
SumUsingReduceInto                                       281     441     +56.9%    **0.64x**
DropWhileSequenceLazy                                    49      76      +55.1%    **0.64x (?)**
FlattenListLoop                                          961     1385    +44.1%    **0.69x (?)**
DropWhileArray                                           27      38      +40.7%    **0.71x (?)**
EqualStringSubstring                                     22      30      +36.4%    **0.73x (?)**
EqualSubstringSubstringGenericEquatable                  22      30      +36.4%    **0.73x (?)**
EqualSubstringString                                     22      30      +36.4%    **0.73x (?)**
MapReduceLazyCollection                                  65      87      +33.8%    **0.75x**
DataCreateSmallArray                                     1800    2400    +33.3%    **0.75x (?)**
LessSubstringSubstring                                   22      29      +31.8%    **0.76x (?)**
LessSubstringSubstringGenericComparable                  22      29      +31.8%    **0.76x (?)**
UTF8Decode_InitFromCustom_noncontiguous_ascii            618     809     +30.9%    **0.76x (?)**
SequenceAlgosRange                                       1520    1960    +28.9%    **0.78x (?)**
Dictionary4                                              155     199     +28.4%    **0.78x (?)**
FlattenListFlatMap                                       2577    3260    +26.5%    **0.79x (?)**
EqualSubstringSubstring                                  23      29      +26.1%    **0.79x (?)**
SequenceAlgosArray                                       1710    2140    +25.1%    **0.80x (?)**
RemoveWhereSwapInts                                      20      25      +25.0%    **0.80x (?)**
UTF8Decode_InitFromCustom_noncontiguous_ascii_as_ascii   726     906     +24.8%    **0.80x (?)**
RemoveWhereMoveStrings                                   279     341     +22.2%    **0.82x (?)**
UTF8Decode_InitFromCustom_noncontiguous                  268     325     +21.3%    **0.82x (?)**
Set.isSuperset.Seq.Box0                                  198     239     +20.7%    **0.83x (?)**
ArrayAppendLatin1Substring                               19296   22536   +16.8%    **0.86x (?)**
ArrayAppendAsciiSubstring                                18972   22140   +16.7%    **0.86x (?)**
ArrayAppendUTF16Substring                                18972   22104   +16.5%    **0.86x (?)**
SIMDRandomMask.Int8x16                                   308     354     +14.9%    **0.87x (?)**
ObjectiveCBridgeStringHash                               85      97      +14.1%    **0.88x (?)**
DropFirstAnySeqCRangeIter                                111     125     +12.6%    **0.89x (?)**
Calculator                                               138     155     +12.3%    **0.89x (?)**
StringComparison_longSharedPrefix                        296     332     +12.2%    **0.89x (?)**
DropFirstAnySeqCntRange                                  111     124     +11.7%    **0.90x (?)**
DropWhileArrayLazy                                       44      49      +11.4%    **0.90x (?)**
SubstringEqualString                                     152     168     +10.5%    **0.90x (?)**
PrefixAnyCollection                                      114     126     +10.5%    **0.90x (?)**
Data.init.Sequence.64kB.Count0.I                         163     180     +10.4%    **0.91x (?)**
SequenceAlgosContiguousArray                             2030    2240    +10.3%    **0.91x (?)**
SubstringEquatable                                       265     292     +10.2%    **0.91x (?)**
SortStringsUnicode                                       2015    2220    +10.2%    **0.91x (?)**
ProtocolDispatch                                         217     239     +10.1%    **0.91x (?)**
DropLastAnyCollection                                    40      44      +10.0%    **0.91x (?)**
BridgeString.find.native.longNonASCII                    398     437     +9.8%     **0.91x (?)**
Chars2                                                   3150    3450    +9.5%     **0.91x (?)**
Set.isStrictSubset.Box0                                  75      82      +9.3%     **0.91x (?)**
ObjectiveCBridgeStringGetASCIIContents                   318     347     +9.1%     **0.92x (?)**
ArrayAppendLazyMap                                       1440    1560    +8.3%     **0.92x (?)**
DropWhileAnyCollectionLazy                               157     170     +8.3%     **0.92x (?)**
Set.isStrictSubset.Int.Empty                             37      40      +8.1%     **0.93x (?)**
DataCreateMediumArray                                    1540    1660    +7.8%     **0.93x (?)**
Data.init.Sequence.64kB.Count0.RE                        167     180     +7.8%     **0.93x (?)**
RandomDoubleOpaqueLCG                                    305     328     +7.5%     **0.93x (?)**

IMPROVEMENT                                              OLD     NEW     DELTA     RATIO
Set.subtracting.Box.Empty                                37      23      -37.8%    **1.61x**
Set.subtracting.Int.Empty                                43      28      -34.9%    **1.54x**
RecursiveOwnedParameter                                  284     221     -22.2%    **1.29x (?)**
ObjectiveCBridgeStubDataAppend                           2460    2060    -16.3%    **1.19x (?)**
DataSubscriptMedium                                      45      39      -13.3%    **1.15x**
StringBuilder                                            202     178     -11.9%    **1.13x (?)**
StringBuilderSmallReservingCapacity                      209     186     -11.0%    **1.12x (?)**
StringUTF16Builder                                       210     190     -9.5%     **1.11x (?)**
StringAdder                                              265     241     -9.1%     **1.10x (?)**
String.replaceSubrange.ArrChar.Small                     46      42      -8.7%     **1.10x (?)**
RemoveWhereFilterString                                  211     196     -7.1%     **1.08x (?)**
LineSink.characters.complex                              381     355     -6.8%     **1.07x (?)**

------- Code size: -Osize -------

REGRESSION                                         OLD     NEW     DELTA   RATIO
StrToInt.o                                         4269    4642    +8.7%   **0.92x**
ObjectiveCBridgingStubs.o                          16896   18362   +8.7%   **0.92x**
BinaryFloatingPointConversionFromBinaryInteger.o   28613   29486   +3.1%   **0.97x**
NSDictionaryCastToSwift.o                          1403    1441    +2.7%   **0.97x**
InsertCharacter.o                                  3983    4073    +2.3%   **0.98x**
DictOfArraysToArrayOfDicts.o                       19881   20277   +2.0%   **0.98x**
SubstringTest.o                                    19488   19819   +1.7%   **0.98x**
COWTree.o                                          11278   11434   +1.4%   **0.99x**
DictTest4.o                                        11274   11425   +1.3%   **0.99x**
DictTest4Legacy.o                                  11513   11664   +1.3%   **0.99x**
Suffix.o                                           23781   24078   +1.2%   **0.99x**
Combos.o                                           5957    6029    +1.2%   **0.99x**
BucketSort.o                                       8463    8564    +1.2%   **0.99x**

IMPROVEMENT                                        OLD     NEW     DELTA   RATIO
DictionaryKeysContains.o                           7814    7574    -3.1%   **1.03x**

------- Performance (x86_64): -Onone -------

REGRESSION                                OLD     NEW     DELTA    RATIO
EqualSubstringSubstringGenericEquatable   51      59      +15.7%   **0.86x (?)**
ObjectiveCBridgeStringHash                84      97      +15.5%   **0.87x (?)**
EqualSubstringSubstring                   53      61      +15.1%   **0.87x (?)**
EqualStringSubstring                      53      61      +15.1%   **0.87x (?)**
EqualSubstringString                      53      61      +15.1%   **0.87x (?)**
LessSubstringSubstringGenericComparable   52      59      +13.5%   **0.88x (?)**
CStringShortAscii                         2580    2910    +12.8%   **0.89x (?)**
CStringLongNonAscii                       218     244     +11.9%   **0.89x (?)**
LessSubstringSubstring                    54      60      +11.1%   **0.90x (?)**
BridgeString.find.native.longNonASCII     398     437     +9.8%    **0.91x (?)**
ObjectiveCBridgeStringGetASCIIContents    317     347     +9.5%    **0.91x (?)**
CharIteration_chinese_unicodeScalars      39320   42920   +9.2%    **0.92x (?)**
CStringLongAscii                          219     239     +9.1%    **0.92x (?)**
DictionarySwapAt                          2520    2728    +8.3%    **0.92x (?)**

IMPROVEMENT                               OLD     NEW     DELTA    RATIO
IterateData                               2451    2193    -10.5%   **1.12x (?)**
Set.subtracting.Box.Empty                 110     99      -10.0%   **1.11x (?)**
Set.subtracting.Int.Empty                 121     109     -9.9%    **1.11x (?)**
ParseFloat.Double.Exp                     11      10      -9.1%    **1.10x (?)**
ParseFloat.Float.Exp                      11      10      -9.1%    **1.10x (?)**
ObjectiveCBridgeStubFromNSDateRef         3350    3090    -7.8%    **1.08x (?)**
RemoveWhereFilterString                   314     293     -6.7%    **1.07x (?)**

------- Code size: -swiftlibs -------

REGRESSION                      OLD       NEW       DELTA   RATIO
libswift_MatchingEngine.dylib   671744    688128    +2.4%   **0.98x**

IMPROVEMENT                     OLD       NEW       DELTA   RATIO
libswiftCore.dylib              4685824   4636672   -1.0%   **1.01x**

@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler nate-chandler force-pushed the lexical_lifetimes/destroy-hoisting/disable branch from 54867dd to 6057e37 Compare February 24, 2022 22:10
@nate-chandler
Copy link
Contributor Author 

------- Performance (x86_64): -O -------

REGRESSION                             OLD     NEW     DELTA     RATIO
StringFromLongWholeSubstring           2       8       +299.9%   **0.25x**
StringFromLongWholeSubstringGeneric    3       9       +199.9%   **0.33x**
DataCreateEmptyArray                   750     1350    +80.0%    **0.56x**
Set.isSuperset.Seq.Box0                126     200     +58.7%    **0.63x**
ArrayAppendLatin1Substring             8820    11988   +35.9%    **0.74x (?)**
ArrayAppendUTF16Substring              8676    11700   +34.9%    **0.74x**
ArrayAppendAsciiSubstring              8676    11700   +34.9%    **0.74x (?)**
DataCreateSmallArray                   1350    1700    +25.9%    **0.79x (?)**
ArrayAppendRepeatCol                   400     500     +25.0%    **0.80x (?)**
RemoveWhereMoveStrings                 281     340     +21.0%    **0.83x**
SumUsingReduce                         69      83      +20.3%    **0.83x**
SumUsingReduceInto                     74      83      +12.2%    **0.89x**
Set.isDisjoint.Box.Empty               43      47      +9.3%     **0.91x (?)**

IMPROVEMENT                            OLD     NEW     DELTA     RATIO
Set.subtracting.Box.Empty              38      24      -36.8%    **1.58x**
Data.append.Sequence.64kB.Count.RE.I   29      21      -27.6%    **1.38x**
Data.append.Sequence.64kB.Count.RE     29      21      -27.6%    **1.38x**
BinaryFloatingPointPropertiesUlp       26      19      -26.9%    **1.37x**
Set.isDisjoint.Seq.Empty.Int           5       4       -20.0%    **1.25x**
Breadcrumbs.MutatedIdxToUTF16.Mixed    220     187     -15.0%    **1.18x**
Breadcrumbs.MutatedUTF16ToIdx.Mixed    213     183     -14.1%    **1.16x (?)**
DataAppendSequence                     6800    5900    -13.2%    **1.15x (?)**
Data.append.Sequence.809B.Count.RE     68      59      -13.2%    **1.15x (?)**
Data.append.Sequence.809B.Count.RE.I   68      59      -13.2%    **1.15x (?)**
StringUTF16Builder                     210     190     -9.5%     **1.11x (?)**
NopDeinit                              31600   28900   -8.5%     **1.09x (?)**
StringBuilderSmallReservingCapacity    205     189     -7.8%     **1.08x (?)**
ObjectiveCBridgeToNSArray              7950    7350    -7.5%     **1.08x (?)**
StringBuilder                          199     184     -7.5%     **1.08x (?)**
StringBuilderWithLongSubstring         1070    990     -7.5%     **1.08x (?)**
Set.isStrictSubset.Seq.Box0            287     266     -7.3%     **1.08x (?)**
ArraySetElement                        305     284     -6.9%     **1.07x (?)**
NormalizedIterator_ascii               74      69      -6.8%     **1.07x (?)**

------- Code size: -O -------

REGRESSION                                         OLD     NEW     DELTA   RATIO
DictOfArraysToArrayOfDicts.o                       22559   23375   +3.6%   **0.97x**
NSDictionaryCastToSwift.o                          1498    1546    +3.2%   **0.97x**
BinaryFloatingPointConversionFromBinaryInteger.o   29608   30376   +2.6%   **0.97x**
SubstringTest.o                                    18197   18570   +2.0%   **0.98x**
DictTest4.o                                        14866   15058   +1.3%   **0.99x**
Walsh.o                                            5148    5212    +1.2%   **0.99x**
ProtocolConformance.o                              4039    4087    +1.2%   **0.99x**
MonteCarloE.o                                      2777    2809    +1.2%   **0.99x**
DictTest4Legacy.o                                  15280   15456   +1.2%   **0.99x**
IndexPathTest.o                                    9266    9370    +1.1%   **0.99x**
ArrayAppend.o                                      24521   24793   +1.1%   **0.99x**
Combos.o                                           5790    5854    +1.1%   **0.99x**
ReversedCollections.o                              8340    8428    +1.1%   **0.99x**
RGBHistogram.o                                     21346   21570   +1.0%   **0.99x**

IMPROVEMENT                                        OLD     NEW     DELTA   RATIO
ErrorHandling.o                                    3393    3233    -4.7%   **1.05x**
DictionaryKeysContains.o                           8462    8232    -2.7%   **1.03x**
FloatingPointParsing.o                             17029   16613   -2.4%   **1.03x**
CSVParsing.o                                       54049   53233   -1.5%   **1.02x**
XorLoop.o                                          1586    1570    -1.0%   **1.01x**

------- Performance (x86_64): -Osize -------

REGRESSION                                          OLD     NEW     DELTA     RATIO
StringFromLongWholeSubstring                        2       8       +299.9%   **0.25x**
StringFromLongWholeSubstringGeneric                 3       9       +199.9%   **0.33x**
FlattenListFlatMap                                  2267    4166    +83.8%    **0.54x (?)**
DataCreateEmptyArray                                900     1550    +72.2%    **0.58x**
SumUsingReduceInto                                  282     440     +56.0%    **0.64x (?)**
PrefixWhileAnySeqCRangeIterLazy                     17      26      +52.9%    **0.65x (?)**
PrefixWhileAnySeqCntRangeLazy                       17      26      +52.9%    **0.65x (?)**
FlattenListLoop                                     962     1384    +43.9%    **0.70x (?)**
DataCountSmall                                      15      21      +40.0%    **0.71x (?)**
MapReduceLazySequence                               65      87      +33.8%    **0.75x (?)**
DataCreateSmallArray                                1800    2400    +33.3%    **0.75x (?)**
DropLastAnyCollection                               31      39      +25.8%    **0.79x (?)**
DataCountMedium                                     17      21      +23.5%    **0.81x (?)**
DropFirstAnySeqCRangeIterLazy                       111     136     +22.5%    **0.82x**
DropFirstAnySeqCntRangeLazy                         111     136     +22.5%    **0.82x**
RemoveWhereMoveStrings                              281     341     +21.4%    **0.82x (?)**
ArrayAppendLazyMap                                  1430    1730    +21.0%    **0.83x (?)**
Set.isSuperset.Seq.Box0                             192     231     +20.3%    **0.83x (?)**
DataSubscriptSmall                                  16      19      +18.7%    **0.84x (?)**
MapReduceString                                     38      44      +15.8%    **0.86x (?)**
ArrayLiteral2                                       82      93      +13.4%    **0.88x (?)**
DataCreateMedium                                    7900    8800    +11.4%    **0.90x (?)**
CharIteration_tweet_unicodeScalars                  5440    6000    +10.3%    **0.91x (?)**
CharIteration_ascii_unicodeScalars                  2760    3040    +10.1%    **0.91x (?)**
ObjectiveCBridgeStubToNSStringRef                   89      98      +10.1%    **0.91x (?)**
CharIteration_tweet_unicodeScalars_Backwards        7400    8120    +9.7%     **0.91x (?)**
CharIteration_punctuated_unicodeScalars_Backwards   840     920     +9.5%     **0.91x (?)**
CharIteration_russian_unicodeScalars                2960    3240    +9.5%     **0.91x (?)**
RemoveWhereSwapInts                                 23      25      +8.7%     **0.92x (?)**
CharIteration_ascii_unicodeScalars_Backwards        3760    4080    +8.5%     **0.92x (?)**
CharIteration_japanese_unicodeScalars               4320    4680    +8.3%     **0.92x (?)**
ArrayAppendAscii                                    1768    1904    +7.7%     **0.93x (?)**
ArrayAppendLatin1                                   1768    1904    +7.7%     **0.93x (?)**
ArrayAppendUTF16                                    1768    1904    +7.7%     **0.93x (?)**
Data.init.Sequence.2047B.Count.I                    52      56      +7.7%     **0.93x (?)**
Data.init.Sequence.2049B.Count.I                    52      56      +7.7%     **0.93x (?)**
Data.hash.Empty                                     52      56      +7.7%     **0.93x (?)**

IMPROVEMENT                                         OLD     NEW     DELTA     RATIO
Set.subtracting.Box.Empty                           38      24      -36.8%    **1.58x**
SumUsingReduce                                      440     281     -36.1%    **1.57x**
Data.init.Sequence.64kB.Count.RE.I                  29      19      -34.5%    **1.53x (?)**
Data.init.Sequence.64kB.Count.RE                    29      19      -34.5%    **1.53x (?)**
Data.append.Sequence.64kB.Count.RE.I                29      20      -31.0%    **1.45x (?)**
Data.append.Sequence.64kB.Count.RE                  29      20      -31.0%    **1.45x (?)**
MapReduceLazyCollectionShort                        89      67      -24.7%    **1.33x**
PrefixAnyCollection                                 111     84      -24.3%    **1.32x (?)**
DropFirstAnySeqCRangeIter                           111     85      -23.4%    **1.31x**
DropFirstAnySeqCntRange                             111     85      -23.4%    **1.31x (?)**
DropWhileAnySeqCRangeIterLazy                       162     125     -22.8%    **1.30x**
DropWhileAnySeqCntRangeLazy                         162     125     -22.8%    **1.30x**
Data.init.Sequence.809B.Count.RE                    54      43      -20.4%    **1.26x**
Data.init.Sequence.809B.Count.RE.I                  54      43      -20.4%    **1.26x (?)**
PointerArithmetics                                  24500   19600   -20.0%    **1.25x (?)**
PrefixWhileAnyCollection                            138     112     -18.8%    **1.23x**
Data.append.Sequence.809B.Count.RE                  70      57      -18.6%    **1.23x (?)**
Data.append.Sequence.809B.Count.RE.I                70      57      -18.6%    **1.23x**
RemoveWhereFilterInts                               27      22      -18.5%    **1.23x (?)**
DataAppendSequence                                  7000    5800    -17.1%    **1.21x (?)**
Breadcrumbs.MutatedUTF16ToIdx.Mixed                 217     181     -16.6%    **1.20x (?)**
ObjectiveCBridgeStubDataAppend                      2500    2120    -15.2%    **1.18x (?)**
Breadcrumbs.MutatedIdxToUTF16.Mixed                 220     187     -15.0%    **1.18x (?)**
SequenceAlgosContiguousArray                        2250    1920    -14.7%    **1.17x (?)**
ArrayAppendLatin1Substring                          22608   19332   -14.5%    **1.17x (?)**
ObjectiveCBridgeStubDateAccess                      152     130     -14.5%    **1.17x (?)**
ArrayAppendUTF16Substring                           22140   18972   -14.3%    **1.17x (?)**
ArrayAppendAsciiSubstring                           22104   18972   -14.2%    **1.17x (?)**
DataSubscriptMedium                                 43      37      -14.0%    **1.16x (?)**
PrefixWhileAnyCollectionLazy                        107     94      -12.1%    **1.14x (?)**
PrefixAnySeqCRangeIterLazy                          107     94      -12.1%    **1.14x (?)**
PrefixAnySeqCntRangeLazy                            107     94      -12.1%    **1.14x**
SortIntPyramid                                      820     730     -11.0%    **1.12x (?)**
MapReduceAnyCollection                              162     145     -10.5%    **1.12x (?)**
DropWhileArray                                      29      26      -10.3%    **1.12x (?)**
StringUTF16Builder                                  220     200     -9.1%     **1.10x (?)**
Data.append.Sequence.64kB.Count0.I                  175     162     -7.4%     **1.08x (?)**
Data.init.Sequence.64kB.Count0.I                    176     163     -7.4%     **1.08x (?)**
StrToInt                                            990     920     -7.1%     **1.08x (?)**
Data.init.Sequence.64kB.Count0                      175     163     -6.9%     **1.07x (?)**
DictionaryKeysContainsNative                        15      14      -6.7%     **1.07x (?)**
RGBHistogram                                        2110    1970    -6.6%     **1.07x (?)**

------- Code size: -Osize -------

REGRESSION                                         OLD     NEW     DELTA   RATIO
ObjectiveCBridgingStubs.o                          16529   17998   +8.9%   **0.92x**
StrToInt.o                                         4249    4622    +8.8%   **0.92x**
BinaryFloatingPointConversionFromBinaryInteger.o   28613   29486   +3.1%   **0.97x**
NSDictionaryCastToSwift.o                          1383    1421    +2.7%   **0.97x**
DictOfArraysToArrayOfDicts.o                       19853   20249   +2.0%   **0.98x**
SubstringTest.o                                    20674   21014   +1.6%   **0.98x**
COWTree.o                                          11251   11407   +1.4%   **0.99x**
DictTest4.o                                        11230   11381   +1.3%   **0.99x**
DictTest4Legacy.o                                  11454   11605   +1.3%   **0.99x**
Suffix.o                                           23507   23804   +1.3%   **0.99x**
Combos.o                                           5937    6009    +1.2%   **0.99x**
BucketSort.o                                       8554    8655    +1.2%   **0.99x**

IMPROVEMENT                                        OLD     NEW     DELTA   RATIO
DictionaryKeysContains.o                           7749    7509    -3.1%   **1.03x**
InsertCharacter.o                                  4547    4487    -1.3%   **1.01x**

------- Performance (x86_64): -Onone -------

REGRESSION                            OLD     NEW    DELTA    RATIO
CStringShortAscii                     2600    2880   +10.8%   **0.90x (?)**
CStringLongNonAscii                   227     249    +9.7%    **0.91x (?)**
DictionarySwapAt                      2520    2740   +8.7%    **0.92x (?)**

IMPROVEMENT                           OLD     NEW    DELTA    RATIO
Breadcrumbs.MutatedIdxToUTF16.Mixed   230     196    -14.8%   **1.17x**
Breadcrumbs.MutatedUTF16ToIdx.Mixed   218     187    -14.2%   **1.17x (?)**
Set.subtracting.Int.Empty             121     107    -11.6%   **1.13x**
Set.subtracting.Box.Empty             109     98     -10.1%   **1.11x (?)**
IterateData                           2452    2242   -8.6%    **1.09x (?)**
SIMDReduce.Int8                       6754    6185   -8.4%    **1.09x (?)**
ObjectiveCBridgeToNSSet               10450   9750   -6.7%    **1.07x (?)**

------- Code size: -swiftlibs -------

REGRESSION                      OLD       NEW       DELTA   RATIO
libswift_MatchingEngine.dylib   671744    688128    +2.4%   **0.98x**

IMPROVEMENT                     OLD       NEW       DELTA   RATIO
libswiftCore.dylib              4685824   4636672   -1.0%   **1.01x**

@nate-chandler nate-chandler force-pushed the lexical_lifetimes/destroy-hoisting/disable branch from 6057e37 to 72c6b2c Compare February 25, 2022 17:46
@nate-chandler
Copy link
Contributor Author

@swift-ci please benchmark

1 similar comment
@nate-chandler
Copy link
Contributor Author

@swift-ci please benchmark

@nate-chandler
Copy link
Contributor Author 

------- Performance (x86_64): -O -------

REGRESSION                             OLD    NEW     DELTA    RATIO
DataCreateEmptyArray                   750    1300    +73.3%   **0.58x**
Set.isSuperset.Seq.Box0                126    200     +58.7%   **0.63x**
ArrayAppendLatin1Substring             8820   12024   +36.3%   **0.73x (?)**
ArrayAppendUTF16Substring              8640   11736   +35.8%   **0.74x (?)**
ArrayAppendAsciiSubstring              8640   11700   +35.4%   **0.74x (?)**
DataCreateSmallArray                   1300   1650    +26.9%   **0.79x (?)**
ArrayAppendRepeatCol                   400    500     +25.0%   **0.80x (?)**
RemoveWhereMoveStrings                 281    341     +21.4%   **0.82x (?)**
SumUsingReduce                         69     83      +20.3%   **0.83x (?)**
StringBuilder                          176    192     +9.1%    **0.92x (?)**
StringBuilderSmallReservingCapacity    184    199     +8.2%    **0.92x (?)**

IMPROVEMENT                            OLD    NEW     DELTA    RATIO
Data.append.Sequence.64kB.Count.RE.I   29     21      -27.6%   **1.38x**
Data.append.Sequence.64kB.Count.RE     29     21      -27.6%   **1.38x (?)**
BinaryFloatingPointPropertiesUlp       26     19      -26.9%   **1.37x (?)**
Set.isDisjoint.Seq.Empty.Int           5      4       -20.0%   **1.25x (?)**
DataAppendSequence                     6700   5400    -19.4%   **1.24x (?)**
Fibonacci                              6      5       -16.7%   **1.20x (?)**
Data.append.Sequence.809B.Count.RE     67     58      -13.4%   **1.16x (?)**
Data.append.Sequence.809B.Count.RE.I   67     58      -13.4%   **1.16x (?)**
TypeName                               636    570     -10.4%   **1.12x (?)**
OpenClose                              45     41      -8.9%    **1.10x (?)**
Calculator                             118    108     -8.5%    **1.09x (?)**
UTF8Decode_InitFromCustom_contiguous   136    126     -7.4%    **1.08x (?)**
Set.isDisjoint.Int.Empty               42     39      -7.1%    **1.08x (?)**
RemoveWhereFilterString                211    196     -7.1%    **1.08x (?)**
Set.isStrictSubset.Seq.Box0            286    266     -7.0%    **1.08x (?)**

------- Code size: -O -------

REGRESSION                                         OLD     NEW     DELTA   RATIO
DictOfArraysToArrayOfDicts.o                       22559   23375   +3.6%   **0.97x**
NSDictionaryCastToSwift.o                          1498    1546    +3.2%   **0.97x**
BinaryFloatingPointConversionFromBinaryInteger.o   29608   30376   +2.6%   **0.97x**
SubstringTest.o                                    18197   18538   +1.9%   **0.98x**
DictTest4.o                                        14866   15058   +1.3%   **0.99x**
Walsh.o                                            5148    5212    +1.2%   **0.99x**
ProtocolConformance.o                              4039    4087    +1.2%   **0.99x**
MonteCarloE.o                                      2777    2809    +1.2%   **0.99x**
DictTest4Legacy.o                                  15280   15456   +1.2%   **0.99x**
IndexPathTest.o                                    9266    9370    +1.1%   **0.99x**
COWTree.o                                          11530   11658   +1.1%   **0.99x**
ArrayAppend.o                                      24521   24793   +1.1%   **0.99x**
Combos.o                                           5790    5854    +1.1%   **0.99x**
ReversedCollections.o                              8340    8428    +1.1%   **0.99x**
TestsUtils.o                                       29736   30048   +1.0%   **0.99x**

IMPROVEMENT                                        OLD     NEW     DELTA   RATIO
CSVParsing.o                                       54049   53233   -1.5%   **1.02x**
XorLoop.o                                          1586    1570    -1.0%   **1.01x**


------- Performance (x86_64): -Osize -------

REGRESSION                                          OLD    NEW    DELTA    RATIO
DataCreateEmptyArray                                900    1450   +61.1%   **0.62x**
SumUsingReduceInto                                  282    440    +56.0%   **0.64x**
DataCountSmall                                      15     21     +40.0%   **0.71x (?)**
DataCountMedium                                     15     21     +40.0%   **0.71x (?)**
MapReduceLazySequence                               65     87     +33.8%   **0.75x**
Set.filter.Int100.16k                               21     27     +28.6%   **0.78x (?)**
DataCreateSmallArray                                1850   2350   +27.0%   **0.79x (?)**
Set.filter.Int100.20k                               26     33     +26.9%   **0.79x (?)**
DataSubscriptSmall                                  15     19     +26.7%   **0.79x (?)**
Set.filter.Int100.28k                               38     48     +26.3%   **0.79x (?)**
Set.filter.Int100.24k                               31     39     +25.8%   **0.79x (?)**
DropLastAnyCollection                               31     39     +25.8%   **0.79x (?)**
DropFirstAnySeqCRangeIterLazy                       111    136    +22.5%   **0.82x (?)**
DropFirstAnySeqCntRangeLazy                         111    136    +22.5%   **0.82x (?)**
RemoveWhereMoveStrings                              280    343    +22.5%   **0.82x (?)**
ArrayAppendLazyMap                                  1430   1730   +21.0%   **0.83x (?)**
StringInterpolationManySmallSegments                7200   8600   +19.4%   **0.84x (?)**
Set.isSuperset.Seq.Box0                             193    230    +19.2%   **0.84x (?)**
RemoveWhereSwapInts                                 23     27     +17.4%   **0.85x (?)**
MapReduceString                                     38     43     +13.2%   **0.88x (?)**
DataCreateMedium                                    7900   8800   +11.4%   **0.90x (?)**
Data.hash.Empty                                     47     52     +10.6%   **0.90x (?)**
CharIteration_tweet_unicodeScalars                  5440   6000   +10.3%   **0.91x (?)**
CharIteration_ascii_unicodeScalars                  2760   3040   +10.1%   **0.91x (?)**
StringBuilder                                       184    202    +9.8%    **0.91x (?)**
CharIteration_tweet_unicodeScalars_Backwards        7400   8120   +9.7%    **0.91x (?)**
CharIteration_punctuated_unicodeScalars_Backwards   840    920    +9.5%    **0.91x (?)**
CharIteration_russian_unicodeScalars                2960   3240   +9.5%    **0.91x (?)**
StringToDataEmpty                                   550    600    +9.1%    **0.92x (?)**
StringBuilderSmallReservingCapacity                 191    208    +8.9%    **0.92x (?)**
SuffixAnyCollection                                 35     38     +8.6%    **0.92x (?)**
CharIteration_ascii_unicodeScalars_Backwards        3760   4080   +8.5%    **0.92x (?)**
CharIteration_japanese_unicodeScalars               4320   4680   +8.3%    **0.92x (?)**
ArrayAppendLatin1                                   1768   1904   +7.7%    **0.93x (?)**
ArrayAppendUTF16                                    1768   1904   +7.7%    **0.93x (?)**
StringToDataSmall                                   650    700    +7.7%    **0.93x (?)**
Data.init.Sequence.2047B.Count.I                    52     56     +7.7%    **0.93x (?)**

IMPROVEMENT                                         OLD    NEW    DELTA    RATIO
SumUsingReduce                                      440    280    -36.4%   **1.57x**
MapReduceLazyCollectionShort                        89     67     -24.7%   **1.33x (?)**
PrefixAnyCollection                                 111    84     -24.3%   **1.32x**
DropFirstAnySeqCRangeIter                           111    85     -23.4%   **1.31x (?)**
DropFirstAnySeqCntRange                             111    85     -23.4%   **1.31x (?)**
DropWhileAnySeqCRangeIterLazy                       162    125    -22.8%   **1.30x (?)**
DropWhileAnySeqCntRangeLazy                         162    125    -22.8%   **1.30x (?)**
PrefixWhileAnyCollection                            138    111    -19.6%   **1.24x (?)**
ObjectiveCBridgeStubDateAccess                      152    130    -14.5%   **1.17x (?)**
SequenceAlgosContiguousArray                        2240   1920   -14.3%   **1.17x (?)**
Chars2                                              3100   2700   -12.9%   **1.15x (?)**
FlattenListLoop                                     1589   1385   -12.8%   **1.15x (?)**
DropWhileSequence                                   16     14     -12.5%   **1.14x (?)**
PrefixWhileAnyCollectionLazy                        107    94     -12.1%   **1.14x (?)**
PrefixAnySeqCRangeIterLazy                          107    94     -12.1%   **1.14x (?)**
PrefixAnySeqCntRangeLazy                            107    94     -12.1%   **1.14x (?)**
StringComparison_ascii                              183    162    -11.5%   **1.13x (?)**
SortIntPyramid                                      820    730    -11.0%   **1.12x (?)**
Set.isStrictSubset.Int.Empty                        37     33     -10.8%   **1.12x (?)**
DropWhileArray                                      29     26     -10.3%   **1.12x (?)**
Calculator                                          155    141    -9.0%    **1.10x (?)**
OpenClose                                           45     41     -8.9%    **1.10x (?)**
RGBHistogram                                        2130   1960   -8.0%    **1.09x (?)**
DataCopyBytesMedium                                 126    116    -7.9%    **1.09x (?)**
SortSortedStrings                                   68     63     -7.4%    **1.08x (?)**
DictionaryKeysContainsNative                        15     14     -6.7%    **1.07x (?)**

------- Code size: -Osize -------

REGRESSION                                         OLD     NEW     DELTA   RATIO
BinaryFloatingPointConversionFromBinaryInteger.o   28613   29486   +3.1%   **0.97x**
NSDictionaryCastToSwift.o                          1383    1421    +2.7%   **0.97x**
DictOfArraysToArrayOfDicts.o                       19853   20249   +2.0%   **0.98x**
SubstringTest.o                                    20674   20985   +1.5%   **0.99x**
COWTree.o                                          11242   11407   +1.5%   **0.99x**
DictTest4.o                                        11230   11381   +1.3%   **0.99x**
DictTest4Legacy.o                                  11454   11605   +1.3%   **0.99x**
TestsUtils.o                                       23925   24237   +1.3%   **0.99x**
Suffix.o                                           23507   23804   +1.3%   **0.99x**
Combos.o                                           5937    6009    +1.2%   **0.99x**
BucketSort.o                                       8554    8655    +1.2%   **0.99x**

IMPROVEMENT                                        OLD     NEW     DELTA   RATIO
InsertCharacter.o                                  4547    4487    -1.3%   **1.01x**

------- Performance (x86_64): -Onone -------

REGRESSION                           OLD     NEW     DELTA    RATIO
CStringShortAscii                    2580    2870    +11.2%   **0.90x (?)**
NormalizedIterator_slowerPrenormal   280     310     +10.7%   **0.90x (?)**
SIMDReduce.Int8                      6415    6958    +8.5%    **0.92x (?)**
NSDictionaryCastToSwift              2050    2220    +8.3%    **0.92x (?)**
CStringLongNonAscii                  222     240     +8.1%    **0.93x (?)**
DictionarySwapAt                     2520    2720    +7.9%    **0.93x (?)**

IMPROVEMENT                          OLD     NEW     DELTA    RATIO
IterateData                          2499    2197    -12.1%   **1.14x (?)**
StringHasPrefixUnicode               41000   38000   -7.3%    **1.08x (?)**

------- Code size: -swiftlibs -------

REGRESSION                      OLD      NEW      DELTA   RATIO
libswift_MatchingEngine.dylib   671744   688128   +2.4%   **0.98x**

@nate-chandler nate-chandler force-pushed the lexical_lifetimes/destroy-hoisting/disable branch 4 times, most recently from 33d268d to 70d6471 Compare February 26, 2022 02:12
@nate-chandler
Copy link
Contributor Author

@swift-ci please benchmark

atrick
atrick approved these changes Feb 26, 2022
View reviewed changes
Copy link
Contributor

@atrick atrick left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

  • referring the new "fixed pointer handling commit"

@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler
Copy link
Contributor Author

@swift-ci please benchmark

@nate-chandler
Copy link
Contributor Author

@swift-ci please test windows platform

atrick
atrick reviewed Mar 5, 2022
View reviewed changes
lib/SIL/Utils/MemAccessUtils.cpp Outdated
void swift::visitProductLeafAccessPathNodes(SILValue address,
TypeExpansionContext tec,
SILModule &module,
std::function<void(AccessPath::PathNode, SILType)> visitor) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swift::visitProductLeafAccessPathNodes

Very nice!

lib/SILOptimizer/Transforms/SSADestroyHoisting.cpp Outdated
return true;
} else {
assert(load->getOperand()->getType().isTrivial(*load->getFunction()));
bool HoistDestroys::foldBarrier(SILInstruction *barrier,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

foldBarrier

This is awesome. I'm thrilled that it was so easy to do now.

@nate-chandler nate-chandler force-pushed the lexical_lifetimes/destroy-hoisting/disable branch from 8b0d852 to 8626cae Compare March 5, 2022 06:12
@nate-chandler
Copy link
Contributor Author

@swift-ci please benchmark

@nate-chandler
Copy link
Contributor Author

@swift-ci please test windows

@nate-chandler
Copy link
Contributor Author

@swift-ci please benchmark

@nate-chandler nate-chandler force-pushed the lexical_lifetimes/destroy-hoisting/disable branch from 8626cae to d094b19 Compare March 5, 2022 07:48
@nate-chandler
Copy link
Contributor Author

@swift-ci please test source compatibility

@nate-chandler
Copy link
Contributor Author

@swift-ci please test macos platform

@nate-chandler
Copy link
Contributor Author

@swift-ci please benchmark

@nate-chandler nate-chandler force-pushed the lexical_lifetimes/destroy-hoisting/disable branch from 211ca19 to 5b56b76 Compare March 6, 2022 07:30
@atrick
Copy link
Contributor

atrick commented Mar 10, 2022

[MemAccessUtils] Distinguished cast flavors.
Perfect.

atrick
atrick reviewed Mar 10, 2022
View reviewed changes
atrick
atrick reviewed Mar 10, 2022
View reviewed changes
@nate-chandler nate-chandler force-pushed the lexical_lifetimes/destroy-hoisting/disable branch 2 times, most recently from 6cc9875 to 017e8b8 Compare March 12, 2022 00:27
@nate-chandler
Copy link
Contributor Author

@swift-ci please benchmark

@nate-chandler nate-chandler force-pushed the lexical_lifetimes/destroy-hoisting/disable branch from 017e8b8 to 12a15bd Compare March 15, 2022 21:43
@nate-chandler
Copy link
Contributor Author

@swift-ci please benchmark

@nate-chandler nate-chandler force-pushed the lexical_lifetimes/destroy-hoisting/disable branch from 12a15bd to 672ec76 Compare March 17, 2022 03:45
@nate-chandler nate-chandler marked this pull request as ready for review March 17, 2022 03:46
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler
Copy link
Contributor Author

@swift-ci please test source compatibility

1 similar comment
@nate-chandler
Copy link
Contributor Author

@swift-ci please test source compatibility

@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler
Copy link
Contributor Author

@swift-ci please test source compatibility

@nate-chandler
Copy link
Contributor Author

@swift-ci please test source compatibility release

@nate-chandler nate-chandler force-pushed the lexical_lifetimes/destroy-hoisting/disable branch from f04c9a3 to 979196c Compare March 17, 2022 19:07
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler
Copy link
Contributor Author

@swift-ci please test linux platform

@nate-chandler
Copy link
Contributor Author

@swift-ci please clean test linux platform

2 similar comments
@nate-chandler
Copy link
Contributor Author

@swift-ci please clean test linux platform

@nate-chandler
Copy link
Contributor Author

@swift-ci please clean test linux platform

@nate-chandler
Copy link
Contributor Author

@swift-ci please test linux platform

@nate-chandler nate-chandler merged commit b258865 into swiftlang:main Mar 18, 2022
@nate-chandler nate-chandler deleted the lexical_lifetimes/destroy-hoisting/disable branch March 18, 2022 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atrick atrick atrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nate-chandler @atrick