[move-function] Be more pedantic about ensuring that undef dbg value have same scope/loc as the original dbg value. #41490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lvm level uses the same loc. The backend in order to emit correct dwarf requires the debug info part of the dbg.addr or dbg.value to be exactly the same, including the line info. We obey this in the examples in tree today and these test additions validate that they continue to work correctly.
…ame scope as the original llvm.dbg.addr.
…m-ir FileCheck tests.
|
@swift-ci smoke test |
|
@swift-ci smoke test linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, LLVM doesn't consider them to be the same. I also added some tests to validate this behavior.