Skip to content

[Sema] Attempt diagnose generic arg ambiguity if all solutions produce generic arg mismatch #41506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2022
Merged

[Sema] Attempt diagnose generic arg ambiguity if all solutions produce generic arg mismatch #41506

merged 1 commit into from
Feb 23, 2022

Conversation

LucianoPAlmeida
Copy link
Contributor

I think It does makes sense to attempt detect conflicting generic argument if all solutions produce GenericArgumentsMismatch as well.

Resolves SR-15843.

hamishknight
hamishknight reviewed Feb 22, 2022
View reviewed changes
@LucianoPAlmeida LucianoPAlmeida force-pushed the SR-15843-generic-ambiguity branch from eb2ddd8 to 3f422e5 Compare February 22, 2022 20:36
@LucianoPAlmeida LucianoPAlmeida force-pushed the SR-15843-generic-ambiguity branch 2 times, most recently from d4fd593 to 217d10c Compare February 22, 2022 21:05
xedin
xedin reviewed Feb 22, 2022
View reviewed changes
@LucianoPAlmeida LucianoPAlmeida force-pushed the SR-15843-generic-ambiguity branch from 217d10c to 7d0fe8f Compare February 23, 2022 01:18
xedin
xedin reviewed Feb 23, 2022
View reviewed changes
@LucianoPAlmeida LucianoPAlmeida force-pushed the SR-15843-generic-ambiguity branch from 7d0fe8f to 163edcf Compare February 23, 2022 01:38
@LucianoPAlmeida LucianoPAlmeida force-pushed the SR-15843-generic-ambiguity branch from 163edcf to 034c4bd Compare February 23, 2022 01:39
@LucianoPAlmeida
Copy link
Contributor Author

@swift-ci Please smoke test

@xedin
Copy link
Contributor

xedin commented Feb 23, 2022

Great! Feel free to merge.

@LucianoPAlmeida LucianoPAlmeida merged commit 4bef7bf into swiftlang:main Feb 23, 2022
@LucianoPAlmeida LucianoPAlmeida deleted the SR-15843-generic-ambiguity branch February 23, 2022 11:56
hamishknight
hamishknight approved these changes Feb 23, 2022
View reviewed changes
@LucianoPAlmeida LucianoPAlmeida mentioned this pull request Feb 23, 2022
Merged
@LucianoPAlmeida LucianoPAlmeida mentioned this pull request Feb 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xedin xedin xedin approved these changes

@hamishknight hamishknight hamishknight approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LucianoPAlmeida @xedin @hamishknight